Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1278803006: Gets //mandoline passing gn check (Closed)

Created:
5 years, 4 months ago by sky
Modified:
5 years, 4 months ago
CC:
chromium-reviews, penghuang+watch-mandoline_chromium.org, sadrul, yzshen+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gets //mandoline passing gn check BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/c202fc81d0b4931cb928672e5cd226e51e501ea9 Cr-Commit-Position: refs/heads/master@{#342890} Committed: https://crrev.com/88d7709e7b708e6bb58cc920bd9e13c5102b2d22 Cr-Commit-Position: refs/heads/master@{#343067}

Patch Set 1 #

Patch Set 2 : revert synced to tip of tree #

Patch Set 3 : fix android #

Patch Set 4 : add include #

Patch Set 5 : notandroid #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -40 lines) Patch
M .gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/app/desktop/main.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 2 3 4 4 chunks +8 lines, -1 line 0 comments Download
A mandoline/services/core_services/application_delegate_factory.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A mandoline/services/core_services/application_delegate_factory_aura.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A mandoline/services/core_services/application_delegate_factory_default.cc View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A mandoline/services/core_services/application_delegate_factory_linux.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A mandoline/services/core_services/application_delegate_factory_notandroid.cc View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 2 4 chunks +11 lines, -30 lines 0 comments Download
M mandoline/services/updater/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/tab/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/browser/BUILD.gn View 3 chunks +10 lines, -2 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
sky
5 years, 4 months ago (2015-08-11 20:24:45 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 4 months ago (2015-08-11 20:42:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278803006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278803006/1
5 years, 4 months ago (2015-08-11 20:43:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 21:04:08 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c202fc81d0b4931cb928672e5cd226e51e501ea9 Cr-Commit-Position: refs/heads/master@{#342890}
5 years, 4 months ago (2015-08-11 21:04:50 UTC) #6
sky
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1287733002/ by sky@chromium.org. ...
5 years, 4 months ago (2015-08-11 22:42:26 UTC) #7
sky
This was reverted because it broke android. I've reopened and fixed it. The fix is ...
5 years, 4 months ago (2015-08-12 18:13:03 UTC) #8
Ben Goodger (Google)
lgtm
5 years, 4 months ago (2015-08-12 19:14:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278803006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278803006/80001
5 years, 4 months ago (2015-08-12 19:15:18 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-12 19:19:59 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 19:20:41 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/88d7709e7b708e6bb58cc920bd9e13c5102b2d22
Cr-Commit-Position: refs/heads/master@{#343067}

Powered by Google App Engine
This is Rietveld 408576698