Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 1278713003: Fix a small leak in CPDF_DataAvail::CheckTrailer(). (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
Spotted while looking at https://code.google.com/p/pdfium/issues/detail?id=45 We need to stop using CPDF_Object::Release(), but that's a bigger ...
5 years, 4 months ago (2015-08-08 00:43:16 UTC) #2
Tom Sepez
lgtm
5 years, 4 months ago (2015-08-11 20:51:58 UTC) #3
Lei Zhang
5 years, 4 months ago (2015-08-11 21:00:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e42e23f34f0a685d6765ba547a26cc2e601efefd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698