Service Worker: Add missing ServiceWorkerDispatcherHost::SendUpdateError.

Service Worker: Add missing ServiceWorkerDispatcherHost::SendUpdateError.

Add ServiceWorkerDispatcherHost::SendUpdateError method as a follow-up patch for
https://codereview.chromium.org/1270513002/.

While working on the layout test, itt has been found that
ServiceWorkerDispatcherHost::UpdateComplete was calling
ServiceWorkerDispatcherHost::SendRegistrationError instead of the missing
ServiceWorkerDispatcherHost::SendUpdateError so the callback in the
renderer-side could not be properly located.

Related CL: https://codereview.chromium.org/1270513002/

BUG=513655
Committed: https://crrev.com/ee412360fbb8b20c0fdd80239ca6a0e99038e1b1
Cr-Commit-Position: refs/heads/master@{#342091}

[jungkees, 2015-08-06 07:09:01]

jungkee.song@samsung.com changed reviewers:
+ jinho.bang@samsung.com, l.gombos@samsung.com

[jungkees, 2015-08-06 07:12:46]

zino@, while working on the layout test, I found it had an issue where the
update() promise is not settled in error cases. And I found the reason that
SendUpdateError method is missing and SendRegistrationError was being called
instead which led the code path to trying to find a callback in a wrong map when
it got back in the renderer. This CL addresses this problem. PTAL.

[zino, 2015-08-06 07:55:34]

On 2015/08/06 07:12:46, jungkees wrote:
> zino@, while working on the layout test, I found it had an issue where the
> update() promise is not settled in error cases. And I found the reason that
> SendUpdateError method is missing and SendRegistrationError was being called
> instead which led the code path to trying to find a callback in a wrong map
when
> it got back in the renderer. This CL addresses this problem. PTAL.

lgtm

[jungkees, 2015-08-06 08:00:02]

jungkee.song@samsung.com changed reviewers:
+ falken@chromium.org, kinuko@chromium.org, michaeln@chromium.org,
nhiroki@chromium.org, tkent@chromium.org

[jungkees, 2015-08-06 08:00:33]

SW OWNERs, PTAL.

[nhiroki (google), 2015-08-06 08:11:26]

On 2015/08/06 08:00:33, jungkees wrote:
> SW OWNERs, PTAL.

LGTM

[nhiroki (google), 2015-08-06 08:13:09]

On 2015/08/06 08:11:26, nhiroki (google) wrote:
> On 2015/08/06 08:00:33, jungkees wrote:
> > SW OWNERs, PTAL.
> 
> LGTM

Please use BUG=513655

[jungkees, 2015-08-06 08:14:36]

The CQ bit was checked by jungkee.song@samsung.com

[commit-bot: I haz the power, 2015-08-06 08:14:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278713002/1

[commit-bot: I haz the power, 2015-08-06 08:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 08:23:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jungkees, 2015-08-06 08:25:08]

nhiroki@, it seems a presubmit error
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
occurs with the following reason:

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/browser/service_worker/service_worker_dispatcher_host.cc
    content/browser/service_worker/service_worker_dispatcher_host.h

It's weird as you gave one.

[nhiroki, 2015-08-06 08:26:50]

On 2015/08/06 08:25:08, jungkees wrote:
> nhiroki@, it seems a presubmit error
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> occurs with the following reason:
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     content/browser/service_worker/service_worker_dispatcher_host.cc
>     content/browser/service_worker/service_worker_dispatcher_host.h
> 
> It's weird as you gave one.

Sorry! I gave LGTM from a wrong address...

[nhiroki, 2015-08-06 08:26:54]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2015-08-06 08:27:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278713002/1

[commit-bot: I haz the power, 2015-08-06 09:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 09:53:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jungkees, 2015-08-06 10:02:08]

The CQ bit was checked by jungkee.song@samsung.com

[commit-bot: I haz the power, 2015-08-06 10:02:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278713002/1

[commit-bot: I haz the power, 2015-08-06 10:43:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-06 10:44:12]

Patchset 1 (id:??) landed as
https://crrev.com/ee412360fbb8b20c0fdd80239ca6a0e99038e1b1
Cr-Commit-Position: refs/heads/master@{#342091}