Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1278703003: Fix off-by-one in Array.concat's max index check (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix off-by-one in Array.concat's max index check The maximum valid index is strictly smaller than the maximum valid length. BUG=chromium:516592 LOG=y R=yangguo@chromium.org Committed: https://crrev.com/087ae1b08aeda52c8add565b2a53e813a477a6ff Cr-Commit-Position: refs/heads/master@{#30040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/runtime/runtime-array.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-581.js View 1 chunk +0 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-516592.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
5 years, 4 months ago (2015-08-06 09:06:04 UTC) #1
Yang
On 2015/08/06 09:06:04, Jakob wrote: lgtm
5 years, 4 months ago (2015-08-06 09:06:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278703003/1
5 years, 4 months ago (2015-08-06 09:06:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 09:57:18 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 09:57:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/087ae1b08aeda52c8add565b2a53e813a477a6ff
Cr-Commit-Position: refs/heads/master@{#30040}

Powered by Google App Engine
This is Rietveld 408576698