Issue 12787002: Fix analyzer warnings in dart:io.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12787002: Fix analyzer warnings in dart:io. (Closed)

Created:
7 years, 9 months ago by Anders Johnsen

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix analyzer warnings in dart:io. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19860

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sdk/lib/io/http_impl.dart	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r19860 (presubmit successful).

7 years, 9 months ago (2013-03-12 13:03:57 UTC) #2

Søren Gjesse

lgtm https://codereview.chromium.org/12787002/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/12787002/diff/1/sdk/lib/io/http_impl.dart#newcode431 sdk/lib/io/http_impl.dart:431: _HttpResponse response = this as _HttpResponse; You don't ...

7 years, 9 months ago (2013-03-12 13:22:10 UTC) #3

Anders Johnsen

7 years, 9 months ago (2013-03-12 13:30:01 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12787002/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/12787002/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:431: _HttpResponse response = this as _HttpResponse;
On 2013/03/12 13:22:10, Søren Gjesse wrote:
> You don't need "as _HttpResponse" here.

The editor told me I did - see new CL :)

Expand Messages | Collapse Messages