Add stats collection for telemetry startup.warm.blank_page test.

components/html_viewer/html_document.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/html_viewer/html_document.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/single_thread_task_runner.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/thread_task_runner_handle.h"
 #include "components/devtools_service/public/cpp/switches.h"
 #include "components/html_viewer/blink_input_events_type_converters.h"
 #include "components/html_viewer/blink_url_request_type_converters.h"
 #include "components/html_viewer/devtools_agent_impl.h"
 #include "components/html_viewer/geolocation_client_impl.h"
 #include "components/html_viewer/global_state.h"
 #include "components/html_viewer/media_factory.h"
+#include "components/html_viewer/stats_collection_controller.h"
 #include "components/html_viewer/web_layer_tree_view_impl.h"
 #include "components/html_viewer/web_storage_namespace_impl.h"
 #include "components/html_viewer/web_url_loader_impl.h"
 #include "components/view_manager/public/cpp/view.h"
 #include "components/view_manager/public/cpp/view_manager.h"
 #include "components/view_manager/public/cpp/view_property.h"
 #include "components/view_manager/public/interfaces/surfaces.mojom.h"
 #include "mojo/application/public/cpp/application_impl.h"
 #include "mojo/application/public/cpp/connect.h"
 #include "mojo/application/public/interfaces/shell.mojom.h"
@@ skipping 208 matching lines @@
 
   // TODO(yzshen): http://crbug.com/498986 Creating DevToolsAgentImpl instances
   // causes html_viewer_apptests flakiness currently. Before we fix that we
   // cannot enable remote debugging (which is required by Telemetry tests) on
   // the bots.
   if (EnableRemoteDebugging()) {
     devtools_agent_.reset(
         new DevToolsAgentImpl(main_frame, html_document_app_->shell()));
   }
 
+  startup_performance_data_collector_ =
+      StatsCollectionController::Install(main_frame, html_document_app_);
+
   GURL url(response->url);
 
   WebURLRequestExtraData* extra_data = new WebURLRequestExtraData;
   extra_data->synthetic_response = response.Pass();
 
   blink::WebURLRequest web_request;
   web_request.initialize();
   web_request.setURL(url);
   web_request.setExtraData(extra_data);
 
@@ skipping 131 matching lines @@
 
 void HTMLDocument::didAddMessageToConsole(
     const blink::WebConsoleMessage& message,
     const blink::WebString& source_name,
     unsigned source_line,
     const blink::WebString& stack_trace) {
   VLOG(1) << "[" << source_name.utf8() << "(" << source_line << ")] "
           << message.text.utf8();
 }
 
+void HTMLDocument::didHandleOnloadEvents(blink::WebLocalFrame* frame) {
+  if (startup_performance_data_collector_.get()) {

[yzshen1, 2015/08/17 05:46:38]

nit: ".get()" is not necessary for null-check. (I think it is preferred by our
style guide that way?)

Besides, although it is not a concern here, in some cases it affects performance
too: 
Using ".get()" forces the InterfacePtr to setup router and handler watching for
the message pipe handle, if it is not set up yet. On the other hand, using "if
(startup_performance_data_collector_)" only checks whether it holds a valid
message pipe handle.

[msw, 2015/08/17 21:25:50]

Done; thanks for the extra info.

+    startup_performance_data_collector_->SetFirstWebContentsMainFrameLoadTime(

[yzshen1, 2015/08/17 05:46:38]

Do you think we should comment on why we call this for every onload event? (And
similarly for line 431)

[msw, 2015/08/17 21:25:50]

The mojom explains that only the first time is recorded, but in the interest of
performance I added static flags in these functions.

+        base::Time::Now().ToInternalValue());
+  }
+}
+
 void HTMLDocument::didFinishLoad(blink::WebLocalFrame* frame) {
   // TODO(msw): Notify AxProvider clients of updates on child frame loads.
   did_finish_load_ = true;
   // Bind any pending AxProviderImpl interface requests.
   for (auto it : ax_provider_requests_)
     ax_providers_.insert(new AxProviderImpl(web_view_, it->Pass()));
   STLDeleteElements(&ax_provider_requests_);
 }
 
 void HTMLDocument::didNavigateWithinPage(
     blink::WebLocalFrame* frame,
     const blink::WebHistoryItem& history_item,
     blink::WebHistoryCommitType commit_type) {
   if (navigator_host_.get())
     navigator_host_->DidNavigateLocally(history_item.urlString().utf8());
 }
 
+void HTMLDocument::didFirstVisuallyNonEmptyLayout(blink::WebLocalFrame* frame) {
+  if (startup_performance_data_collector_) {
+    startup_performance_data_collector_->SetFirstVisuallyNonEmptyLayoutTime(
+        base::Time::Now().ToInternalValue());
+  }
+}
+
 blink::WebEncryptedMediaClient* HTMLDocument::encryptedMediaClient() {
   return global_state_->media_factory()->GetEncryptedMediaClient();
 }
 
 void HTMLDocument::OnViewBoundsChanged(View* view,
                                        const Rect& old_bounds,
                                        const Rect& new_bounds) {
   DCHECK_EQ(view, root_);
   UpdateWebviewSizeFromViewSize();
 }
@@ skipping 40 matching lines @@
 
 void HTMLDocument::UpdateFocus() {
   if (!web_view_)
     return;
   bool is_focused = root_ && root_->HasFocus();
   web_view_->setFocus(is_focused);
   web_view_->setIsActive(is_focused);
 }
 
 }  // namespace html_viewer