mandoline/ui/browser/DEPS - Issue 1278673002: Add stats collection for telemetry startup.warm.blank_page test.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mandoline/ui/browser/DEPS

Issue 1278673002: Add stats collection for telemetry startup.warm.blank_page test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cache and reuse a single mojo:tracing connection in mojo:html_viewer. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/view_manager",	2 "+components/view_manager",

3 "+mandoline/services",	3 "+mandoline/services",

4 "+mojo/application",	4 "+mojo/application",

5 "+mojo/common",	5 "+mojo/common",

6 "+mojo/converters",	6 "+mojo/converters",

	7 "+mojo/runner",
	yzshen1 2015/08/13 15:59:12 It probably shouldn't depend on runner to gain acc It probably shouldn't depend on runner to gain access to the switch definition. I think we should define the switch in mojo/services/tracing/public/cpp/switches.{h,cc} instead. (I did similar things for devtools_service.) msw 2015/08/13 22:12:06 Done. Show quoted text On 2015/08/13 15:59:12, yzshen1 wrote: > It probably shouldn't depend on runner to gain access to the switch definition. > > I think we should define the switch in > mojo/services/tracing/public/cpp/switches.{h,cc} instead. > > (I did similar things for devtools_service.) Done.
7 "+mojo/services/network/public",	8 "+mojo/services/network/public",

	9 "+mojo/services/tracing",
	yzshen1 2015/08/13 15:59:12 Maybe we should put the interface in a public/ sub Maybe we should put the interface in a public/ subfolder? msw 2015/08/13 22:12:06 Done. Show quoted text On 2015/08/13 15:59:12, yzshen1 wrote: > Maybe we should put the interface in a public/ subfolder? Done.
8 "+third_party/mojo/src/mojo/public",	10 "+third_party/mojo/src/mojo/public",

9 "+third_party/mojo_services",	11 "+third_party/mojo_services",

10 "+ui",	12 "+ui",

11 ]	13 ]

OLD	NEW