Add stats collection for telemetry startup.warm.blank_page test.

components/html_viewer/html_document.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_HTML_VIEWER_HTML_DOCUMENT_H_
 #define COMPONENTS_HTML_VIEWER_HTML_DOCUMENT_H_
 
 #include <set>
 
 #include "base/callback.h"
 #include "base/macros.h"
+#include "base/observer_list.h"
 #include "components/html_viewer/ax_provider_impl.h"
 #include "components/html_viewer/touch_handler.h"
 #include "components/view_manager/public/cpp/view_manager_client_factory.h"
 #include "components/view_manager/public/cpp/view_manager_delegate.h"
 #include "components/view_manager/public/cpp/view_observer.h"
 #include "mandoline/services/navigation/public/interfaces/navigation.mojom.h"
 #include "mojo/application/public/cpp/app_lifetime_helper.h"
 #include "mojo/application/public/cpp/interface_factory.h"
 #include "mojo/application/public/cpp/lazy_interface_ptr.h"
 #include "mojo/application/public/cpp/service_provider_impl.h"
@@ skipping 12 matching lines @@
 class ViewManager;
 class View;
 }
 
 namespace html_viewer {
 
 class AxProviderImpl;
 class DevToolsAgentImpl;
 class GeolocationClientImpl;
 class GlobalState;
+class StatsCollectionController;
 class WebLayerTreeViewImpl;
 
 // A view for a single HTML document.
 //
 // HTMLDocument is deleted in one of two ways:
 // . When the View the HTMLDocument is embedded in is destroyed.
 // . Explicitly by way of Destroy().
 class HTMLDocument : public blink::WebViewClient,
                      public blink::WebFrameClient,
                      public mojo::ViewManagerDelegate,
@@ skipping 10 matching lines @@
                  const DeleteCallback& delete_callback);
     ~CreateParams();
 
     mojo::ApplicationImpl* html_document_app;
     mojo::ApplicationConnection* connection;
     mojo::URLResponsePtr response;
     GlobalState* global_state;
     DeleteCallback delete_callback;
   };
 
+  class Observer {

[sky, 2015/08/12 23:54:36]

I'm hoping to nuke HTMLDocument soon. Can you move this to HTMLDOcumentOOPIF?
You may want to push this to HTMLFrame. And move to its own header.

[msw, 2015/08/14 23:20:34]

Nothing actually uses StatsCollectionController::GetTabLoadTiming (the only
reason this observation was needed), so it's removed.

+   public:
+    explicit Observer(HTMLDocument* html_document);
+    virtual ~Observer();
+    virtual void DidStartLoading() {}
+    virtual void DidStopLoading() {}
+    HTMLDocument* html_document() const { return html_document_; }
+   private:
+    HTMLDocument* html_document_;
+    DISALLOW_COPY_AND_ASSIGN(Observer);
+  };
+
   // Load a new HTMLDocument with |response|.
   // |html_document_app| is the application this app was created in, and
   // |connection| the specific connection triggering this new instance.
   // |setup| is used to obtain init type state (such as resources).
   explicit HTMLDocument(CreateParams* params);
 
   // Deletes this object.
   void Destroy();
 
+  void AddObserver(HTMLDocument::Observer* observer);

[sky, 2015/08/12 23:54:36]

Can these two be private since Observer takes care of it for you?

[msw, 2015/08/14 23:20:34]

Removed.

+  void RemoveObserver(HTMLDocument::Observer* observer);
+
   blink::WebView* web_view() const { return web_view_; }
 
  protected:
   ~HTMLDocument() override;
 
   // WebViewClient methods:
   virtual blink::WebStorageNamespace* createSessionStorageNamespace();
 
   // WebWidgetClient methods:
   void initializeLayerTreeView() override;
@@ skipping 14 matching lines @@
   virtual void frameDetached(blink::WebFrame* frame, DetachType type);
   virtual blink::WebCookieJar* cookieJar(blink::WebLocalFrame* frame);
   virtual blink::WebNavigationPolicy decidePolicyForNavigation(
       const NavigationPolicyInfo& info);
   virtual blink::WebGeolocationClient* geolocationClient();
 
   virtual void didAddMessageToConsole(const blink::WebConsoleMessage& message,
                                       const blink::WebString& source_name,
                                       unsigned source_line,
                                       const blink::WebString& stack_trace);
+  virtual void didStartLoading(bool toDifferentDocument);

[yzshen1, 2015/08/13 15:59:11]

naming style: to_different_document, so it is consistent with the other methods.

[msw, 2015/08/14 23:20:34]

Removed.

+  virtual void didStopLoading();
+  virtual void didHandleOnloadEvents(blink::WebLocalFrame* frame);
   virtual void didFinishLoad(blink::WebLocalFrame* frame);
   virtual void didNavigateWithinPage(blink::WebLocalFrame* frame,
                                      const blink::WebHistoryItem& history_item,
                                      blink::WebHistoryCommitType commit_type);
+  virtual void didFirstVisuallyNonEmptyLayout(blink::WebLocalFrame* frame);
   virtual blink::WebEncryptedMediaClient* encryptedMediaClient();
 
  private:
   // Data associated with a child iframe.
   struct ChildFrameData {
     mojo::View* view;
     blink::WebTreeScopeType scope;
   };
 
   // Updates the size and scale factor of the webview and related classes from
@@ skipping 51 matching lines @@
   bool did_finish_load_ = false;
 
   GlobalState* global_state_;
 
   scoped_ptr<TouchHandler> touch_handler_;
 
   scoped_ptr<DevToolsAgentImpl> devtools_agent_;
 
   DeleteCallback delete_callback_;
 
+  StatsCollectionController* stats_collection_controller_;

[yzshen1, 2015/08/13 15:59:11]

Please comment about ownership and when it is null/non-null, etc.

[msw, 2015/08/14 23:20:34]

Hmm, holding gin::Wrappable objects on the heap isn't supported:
https://code.google.com/p/chromium/codesearch#chromium/src/gin/handle.h&l=12
So I've replaced this with a StartupPerformanceDataCollectorPtr.

+  base::ObserverList<HTMLDocument::Observer> observers_;
+
   DISALLOW_COPY_AND_ASSIGN(HTMLDocument);
 };
 
 }  // namespace html_viewer
 
 #endif  // COMPONENTS_HTML_VIEWER_HTML_DOCUMENT_H_