Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 127863002: Cleanup SetUpMath to use InstallConstants helper. (Closed)

Created:
6 years, 11 months ago by Michael Starzinger
Modified:
6 years, 11 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Cleanup SetUpMath to use InstallConstants helper. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M src/math.js View 1 chunk +14 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 11 months ago (2014-01-08 09:34:09 UTC) #1
rossberg
lgtm
6 years, 11 months ago (2014-01-08 10:37:04 UTC) #2
Michael Starzinger
6 years, 11 months ago (2014-01-08 11:56:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698