Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1278613003: Cleanup message_loop.cc (Closed)

Created:
5 years, 4 months ago by lucinka.brozkova
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup message_loop.cc Access kHexRangePrintingFlag through HistogramBase:: and not through instance variable. Accessing through instance variable is also correct, but confusing and can lead to future mistakes, because the variable is in this case null. BUG=517586 Committed: https://crrev.com/0d2bf13aa9865bb69866033b98fb3b78f8b2dcc7 Cr-Commit-Position: refs/heads/master@{#342304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/message_loop/message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
lucinka.brozkova
Hi, Could you please review? Thank you. Lucie
5 years, 4 months ago (2015-08-06 19:42:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278613003/1
5 years, 4 months ago (2015-08-06 19:44:04 UTC) #4
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 4 months ago (2015-08-06 19:44:05 UTC) #6
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-06 20:40:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278613003/1
5 years, 4 months ago (2015-08-07 04:28:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 05:41:21 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 05:42:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d2bf13aa9865bb69866033b98fb3b78f8b2dcc7
Cr-Commit-Position: refs/heads/master@{#342304}

Powered by Google App Engine
This is Rietveld 408576698