Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

Issue 1278593004: Introduce ThreadedInputConnection behind a switch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed ImeTest#testDoesNotHang_rendererCrashes which does not test anything Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
index e8c6be4551084b85a7d79cafe2e712a2c634f304..e347efa191bc7d9d67c3eec66bb4292f64493068 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
@@ -9,7 +9,6 @@ import android.text.TextUtils;
import android.view.View;
import android.view.ViewGroup;
-import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.UrlUtils;
import org.chromium.chrome.R;
@@ -17,6 +16,7 @@ import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;
import org.chromium.chrome.test.ChromeActivityTestCaseBase;
import org.chromium.content.browser.ContentViewCore;
+import org.chromium.content.browser.input.ChromiumBaseInputConnection;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
import org.chromium.content.browser.test.util.DOMUtils;
@@ -173,11 +173,12 @@ public class AutofillPopupTest extends ChromeActivityTestCaseBase<ChromeActivity
waitForKeyboardShowRequest(immw, 1);
- ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ final ChromiumBaseInputConnection inputConnection =
+ viewCore.getImeAdapterForTest().getInputConnectionForTest();
+ inputConnection.getHandler().post(new Runnable() {
@Override
public void run() {
- viewCore.getImeAdapterForTest().getInputConnectionForTest().setComposingText(
- inputText, 1);
+ inputConnection.setComposingText(inputText, 1);
}
});

Powered by Google App Engine
This is Rietveld 408576698