content/renderer/ime_event_guard.cc - Issue 1278593004: Introduce ThreadedInputConnection behind a switch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/ime_event_guard.cc

Issue 1278593004: Introduce ThreadedInputConnection behind a switch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix selection update to be accurate and fix tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/ime_event_guard.cc

diff --git a/content/renderer/ime_event_guard.cc b/content/renderer/ime_event_guard.cc

index aaed1712a7be85267fe7f7c1fe6e20445593ea3c..759d66ef3ec39d937fde9bcb2d8f02d55e628b7a 100644

--- a/content/renderer/ime_event_guard.cc

+++ b/content/renderer/ime_event_guard.cc

@@ -9,13 +9,7 @@

namespace content {

ImeEventGuard::ImeEventGuard(RenderWidget* widget)

- : ImeEventGuard(widget, false, true) {

-ImeEventGuard::ImeEventGuard(RenderWidget* widget, bool show_ime, bool from_ime)

- : widget_(widget),

- show_ime_(show_ime),

- from_ime_(from_ime) {

+ : widget_(widget), show_ime_(false), from_ime_(widget->IsFromImeDefault()) {

widget_->OnImeEventGuardStart(this);

}