chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java - Issue 1278593004: Introduce ThreadedInputConnection behind a switch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

Issue 1278593004: Introduce ThreadedInputConnection behind a switch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: straighten up state update, replace mQueue.poll() by mQueue.take() Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | content/public/android/java/src/org/chromium/content/browser/input/ChromiumInputConnection.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

index e8c6be4551084b85a7d79cafe2e712a2c634f304..6efe398b118c9a69da3187d8bea5dd40586a1b0d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java

@@ -9,7 +9,6 @@ import android.text.TextUtils;

import android.view.View;

import android.view.ViewGroup;

-import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.chrome.R;

@@ -17,6 +16,7 @@ import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

import org.chromium.content.browser.ContentViewCore;

+import org.chromium.content.browser.input.ChromiumBaseInputConnection;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content.browser.test.util.DOMUtils;

@@ -173,11 +173,12 @@ public class AutofillPopupTest extends ChromeActivityTestCaseBase<ChromeActivity

waitForKeyboardShowRequest(immw, 1);

- ThreadUtils.runOnUiThreadBlocking(new Runnable() {

+ final ChromiumBaseInputConnection inputConnection =

+ viewCore.getImeAdapterForTest().getInputConnectionForTest();

+ inputConnection.getThreadManager().post(new Runnable() {

@Override

public void run() {

- viewCore.getImeAdapterForTest().getInputConnectionForTest().setComposingText(

- inputText, 1);

+ inputConnection.setComposingText(inputText, 1);

}

});