Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java

Issue 1278593004: Introduce ThreadedInputConnection behind a switch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java
new file mode 100644
index 0000000000000000000000000000000000000000..dbbf8ae273f4ffb18c946a8881c8e9b029cc3ded
--- /dev/null
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java
@@ -0,0 +1,43 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.content.browser.input;
+
+import android.view.KeyEvent;
+import android.view.View;
+import android.view.inputmethod.InputConnection;
+
+/**
+ * TODO: Insert description here. (generated by changwan)
+ */
+public interface ChromiumBaseInputConnection extends InputConnection {
+ /**
+ * Updates the internal representation of the text being edited and its selection and
+ * composition properties.
+ *
+ * @param text The String contents of the field being edited.
+ * @param selectionStart The character offset of the selection start, or the caret position if
+ * there is no selection.
+ * @param selectionEnd The character offset of the selection end, or the caret position if there
+ * is no selection.
+ * @param compositionStart The character offset of the composition start, or -1 if there is no
+ * composition.
+ * @param compositionEnd The character offset of the composition end, or -1 if there is no
+ * selection.
+ * @param isNonImeChange True when the update was caused by non-IME (e.g. Javascript).
+ */
+ void updateState(String text, int selectionStart, int selectionEnd, int compositionStart,
aelias_OOO_until_Jul13 2015/09/30 00:10:03 Please rename this updateStateOnUiThread.
Changwan Ryu 2016/01/19 07:31:52 Done.
+ int compositionEnd, boolean isNonImeChange);
+
+ /**
+ * Handle key event dispatched from View.
+ * @see View#dispatchKeyEvent(android.view.KeyEvent)
+ */
+ boolean dispatchKeyEvent(KeyEvent event);
aelias_OOO_until_Jul13 2015/09/30 00:10:03 Please rename this sendKeyEventOnUiThread.
Changwan Ryu 2016/01/19 07:31:52 Changed to dispatchKeyEventOnUiThread as this is c
+
+ /**
+ * Restart input.
+ */
+ void restartInput();
aelias_OOO_until_Jul13 2015/09/30 00:10:03 Please rename this restartInputOnUiThread.
Changwan Ryu 2016/01/19 07:31:52 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698