Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2583)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 1278593004: Introduce ThreadedInputConnection behind a switch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index 6651cac896d5179bc780e90e4c44f32bf31f415d..e8ef3e311eb8b1e8915e1fb4bad8c0bffd5c1c2b 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -72,8 +72,7 @@ public class ImeTest extends ContentShellTestBase {
mInputMethodManagerWrapper = new TestInputMethodManagerWrapper(mContentViewCore);
getImeAdapter().setInputMethodManagerWrapper(mInputMethodManagerWrapper);
assertEquals(0, mInputMethodManagerWrapper.getShowSoftInputCounter());
- mContentViewCore.setAdapterInputConnectionFactory(
- new TestAdapterInputConnectionFactory());
+ mContentViewCore.setInputConnectionFactory(new TestAdapterInputConnectionFactory());
mCallbackContainer = new TestCallbackHelperContainer(mContentViewCore);
// TODO(aurimas) remove this wait once crbug.com/179511 is fixed.
@@ -83,7 +82,7 @@ public class ImeTest extends ContentShellTestBase {
DOMUtils.clickNode(this, mContentViewCore, "input_text");
assertWaitForKeyboardStatus(true);
- mConnection = (TestAdapterInputConnection) getAdapterInputConnection();
+ mConnection = (TestAdapterInputConnection) getInputConnection();
mImeAdapter = getImeAdapter();
waitAndVerifyStatesAndCalls(0, "", 0, 0, -1, -1);
@@ -923,7 +922,7 @@ public class ImeTest extends ContentShellTestBase {
@Override
public boolean isSatisfied() {
return show == getImeAdapter().mIsShowWithoutHideOutstanding
- && (!show || getAdapterInputConnection() != null);
+ && (!show || getInputConnection() != null);
}
}));
}
@@ -1009,7 +1008,7 @@ public class ImeTest extends ContentShellTestBase {
return mContentViewCore.getImeAdapterForTest();
}
- private AdapterInputConnection getAdapterInputConnection() {
+ private ChromiumBaseInputConnection getInputConnection() {
return mContentViewCore.getInputConnectionForTest();
}
@@ -1146,15 +1145,15 @@ public class ImeTest extends ContentShellTestBase {
}
}));
// When we focus another element, the connection may be recreated.
- mConnection = (TestAdapterInputConnection) getAdapterInputConnection();
+ mConnection = (TestAdapterInputConnection) getInputConnection();
waitAndVerifyStatesAndCalls(0, "", 0, 0, -1, -1);
}
- private static class TestAdapterInputConnectionFactory extends
- ImeAdapter.AdapterInputConnectionFactory {
+ private static class TestAdapterInputConnectionFactory
+ extends ChromiumBaseInputConnectionFactory {
@Override
- public AdapterInputConnection get(View view, ImeAdapter imeAdapter,
- Editable editable, EditorInfo outAttrs) {
+ public ChromiumBaseInputConnection get(
+ View view, ImeAdapter imeAdapter, Editable editable, EditorInfo outAttrs) {
return new TestAdapterInputConnection(view, imeAdapter, editable, outAttrs);
}
}
@@ -1202,4 +1201,4 @@ public class ImeTest extends ContentShellTestBase {
assertEquals("Composition end did not match", compositionEnd, mCompositionEnd);
}
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698