content/renderer/ime_event_guard.cc - Issue 1278593004: Introduce ThreadedInputConnection behind a switch

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/ime_event_guard.cc

Issue 1278593004: Introduce ThreadedInputConnection behind a switch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed a crash for LatinIME Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java ('K') | « content/public/common/content_switches.cc ('k') | content/renderer/input/render_widget_input_handler.cc » ('j') | content/renderer/render_widget.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/renderer/ime_event_guard.h"	5 #include "content/renderer/ime_event_guard.h"

6	6

7 #include "content/renderer/render_widget.h"	7 #include "content/renderer/render_widget.h"

8	8

9 namespace content {	9 namespace content {

10	10

11 ImeEventGuard::ImeEventGuard(RenderWidget* widget)	11 ImeEventGuard::ImeEventGuard(RenderWidget* widget)

12 : ImeEventGuard(widget, false, true) {	12 : ImeEventGuard(widget, false, widget->IsFromImeDefault()) {

13 }	13 }

14	14

15 ImeEventGuard::ImeEventGuard(RenderWidget* widget, bool show_ime, bool from_ime)	15 ImeEventGuard::ImeEventGuard(RenderWidget* widget, bool show_ime, bool from_ime)
	aelias_OOO_until_Jul13 2016/01/23 03:21:39 This constructor is unreadable because of the bool This constructor is unreadable because of the booleans passed in, so please delete it. The only existing user is RenderWidgetInputHandler::HandleInputEvent which can call set_from_ime() instead. Changwan Ryu 2016/01/26 03:25:28 Done. Show quoted text On 2016/01/23 03:21:39, aelias wrote: > This constructor is unreadable because of the booleans passed in, so please > delete it. The only existing user is RenderWidgetInputHandler::HandleInputEvent > which can call set_from_ime() instead. Done.
16 : widget_(widget),	16 : widget_(widget),

17 show_ime_(show_ime),	17 show_ime_(show_ime),

18 from_ime_(from_ime) {	18 from_ime_(from_ime) {

19 widget_->OnImeEventGuardStart(this);	19 widget_->OnImeEventGuardStart(this);

20 }	20 }

21	21

22 ImeEventGuard::~ImeEventGuard() {	22 ImeEventGuard::~ImeEventGuard() {

23 widget_->OnImeEventGuardFinish(this);	23 widget_->OnImeEventGuardFinish(this);

24 }	24 }

25	25

26 } // namespace content	26 } // namespace content

OLD	NEW