LayoutTests/fast/spatial-navigation/snav-clipped-overflowed-content.html - Issue 1278543002: Include the whole outline into visual overflow

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/spatial-navigation/snav-clipped-overflowed-content.html

Issue 1278543002: Include the whole outline into visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Modify a fast/spatial-navigation test because of fix of original clippedOverflowRect bug Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/repaint/focus-ring-on-continuation-move-expected.txt ('k') | LayoutTests/platform/linux/fast/repaint/focus-continuations-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <!--	2 <!--

3 This test ensures the correctness of a basic aspect of spatial navigation tr aversal	3 This test ensures the correctness of a basic aspect of spatial navigation tr aversal

4 routines: focusable elements in scrollable containers (e.g. <div>) should be	4 routines: focusable elements in scrollable containers (e.g. <div>) should be

5 accessible, including offscreen content.	5 accessible, including offscreen content.

6	6

7 * Pre-conditions:	7 * Pre-conditions:

8 1) DRT support for spatial navivation enable/disable.	8 1) DRT support for spatial navivation enable/disable.

9	9

10 * Navigation steps:	10 * Navigation steps:

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
68 }	68 }

69	69

70 window.onload = runTest;	70 window.onload = runTest;

71	71

72 </script>	72 </script>

73 </head>	73 </head>

74	74

75 <body id="some-content" xmlns="http://www.w3.org/1999/xhtml">	75 <body id="some-content" xmlns="http://www.w3.org/1999/xhtml">

76 <a id="start" href="a"><img src="resources/green.png" width=30px height=30px ></a>	76 <a id="start" href="a"><img src="resources/green.png" width=30px height=30px ></a>

77 <div class="scroll">	77 <div class="scroll">

78 <a id="1" href="a"><img src="resources/green.png" width=30px height=30px>< /a>	78 <a id="1" href="a"><img src="resources/green.png" width=30px height=35px>< /a>
	Xianzhu 2015/08/06 18:12:46 This change is because this CL fixed an original b This change is because this CL fixed an original bug of LayoutInline::clippedOverflowRect which applied outline width twice. The changed result caused different focus navigation behavior. Change the test to make it produce the expected result.
79 <div></div>	79 <div></div>

80 <img src="resources/green.png" width=200px height=200px>	80 <img src="resources/green.png" width=200px height=200px>

81 <div></div>	81 <div></div>

82 <a id="2" href="a"><img src="resources/green.png" width=30px height=30px>< /a>.	82 <a id="2" href="a"><img src="resources/green.png" width=30px height=30px>< /a>.

83 </div>	83 </div>

84 <a id="3" href="a"><img src="resources/green.png" width=30px height=30px></a >	84 <a id="3" href="a"><img src="resources/green.png" width=30px height=30px></a >

85 <div id="console"></div>	85 <div id="console"></div>

86 <div>This test tests that a div with css overflow:auto will scroll to reveal its focusable elements</div>	86 <div>This test tests that a div with css overflow:auto will scroll to reveal its focusable elements</div>

87 </body>	87 </body>

88 </html>	88 </html>

89	89

OLD	NEW