Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 1278483004: Revert of Refactor browser side navigator.connect code to not use MessagePortService. (Closed)

Created:
5 years, 4 months ago by Marijn Kruisselbrink
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@serviceport-serviceside
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor browser side navigator.connect code to not use MessagePortService. (patchset #2 id:60001 of https://codereview.chromium.org/1224263007/ ) Reason for revert: Seems to be crashing on windows. BUG=517281 Original issue's description: > Refactor browser side navigator.connect code to not use MessagePortService. > > This is the first step towards unifying client side and service side ServicePort > instances, but also removes a layer of abstraction in how connections to > services are setup. The abstraction layer will probably later be reintroduced > differently. > > BUG=426458 > > Committed: https://crrev.com/9b053ed8f7b8893ad0a5a33d31546c70563ddf20 > Cr-Commit-Position: refs/heads/master@{#341987} TBR=avi@chromium.org,bsittler@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=426458 Committed: https://crrev.com/f4acab417af4a182dbbb6bbc5aa1235662a9253c Cr-Commit-Position: refs/heads/master@{#342026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -200 lines) Patch
M content/browser/navigator_connect/navigator_connect_context_impl.h View 5 chunks +24 lines, -48 lines 0 comments Download
M content/browser/navigator_connect/navigator_connect_context_impl.cc View 3 chunks +66 lines, -148 lines 0 comments Download
A content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h View 1 chunk +64 lines, -0 lines 0 comments Download
A content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc View 1 chunk +205 lines, -0 lines 0 comments Download
M content/browser/navigator_connect/service_port_service_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marijn Kruisselbrink
Created Revert of Refactor browser side navigator.connect code to not use MessagePortService.
5 years, 4 months ago (2015-08-06 00:29:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278483004/1
5 years, 4 months ago (2015-08-06 00:29:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 00:30:49 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 00:31:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4acab417af4a182dbbb6bbc5aa1235662a9253c
Cr-Commit-Position: refs/heads/master@{#342026}

Powered by Google App Engine
This is Rietveld 408576698