components/omnibox/browser/omnibox_edit_model.cc - Issue 1278433002: Eliminate OmniboxMetricsProvider listening to notification

Unified Diff: components/omnibox/browser/omnibox_edit_model.cc

Issue 1278433002: Eliminate OmniboxMetricsProvider listening to notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_omnibox

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/omnibox_metrics_provider.cc ('K') | « components/omnibox/browser/omnibox_client.h ('k') | components/omnibox/browser/omnibox_event_global_tracker.h » ('j') | components/omnibox/browser/omnibox_event_global_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/omnibox_edit_model.cc

diff --git a/components/omnibox/browser/omnibox_edit_model.cc b/components/omnibox/browser/omnibox_edit_model.cc

index 8e27dd4b68e61f9bbedf63f702db8c1b5432a935..42852388b66c4acc50bb728e9749ae2f1c8b6f37 100644

--- a/components/omnibox/browser/omnibox_edit_model.cc

+++ b/components/omnibox/browser/omnibox_edit_model.cc

@@ -25,6 +25,7 @@

#include "components/omnibox/browser/keyword_provider.h"

#include "components/omnibox/browser/omnibox_client.h"

#include "components/omnibox/browser/omnibox_edit_controller.h"

+#include "components/omnibox/browser/omnibox_event_global_tracker.h"

#include "components/omnibox/browser/omnibox_log.h"

#include "components/omnibox/browser/omnibox_navigation_observer.h"

#include "components/omnibox/browser/omnibox_popup_model.h"

@@ -708,6 +709,7 @@ void OmniboxEditModel::OpenMatch(AutocompleteMatch match,

}

autocomplete_controller()->AddProvidersInfo(&log.providers_info);

client_->OnURLOpenedFromOmnibox(&log);

+ OmniboxEventGlobalTracker::GetInstance()->OnURLOpened(&log);

Alexei Svitkine (slow) 2015/08/06 19:29:03 Seems like you can also eliminate the client_->OnU

Peter Kasting 2015/08/06 19:58:22 I think that would mean that all clients automatic

blundell 2015/08/06 20:22:21 Peter's correct.

Alexei Svitkine (slow) 2015/08/06 20:27:28 Fair enough. I thought there was just a single cli

LOCAL_HISTOGRAM_BOOLEAN("Omnibox.EventCount", true);

DCHECK(!last_omnibox_focus_.is_null())

<< "An omnibox focus should have occurred before opening a match.";