chrome/browser/android/omnibox/autocomplete_controller_android.cc - Issue 1278433002: Eliminate OmniboxMetricsProvider listening to notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/omnibox/autocomplete_controller_android.cc

Issue 1278433002: Eliminate OmniboxMetricsProvider listening to notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_omnibox

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/omnibox/autocomplete_controller_android.cc

diff --git a/chrome/browser/android/omnibox/autocomplete_controller_android.cc b/chrome/browser/android/omnibox/autocomplete_controller_android.cc

index 098eaca2665fffcbc893941c3365829819766629..37b8b1bc222c266f3e51f111b806bc7b59fd3ecf 100644

--- a/chrome/browser/android/omnibox/autocomplete_controller_android.cc

+++ b/chrome/browser/android/omnibox/autocomplete_controller_android.cc

@@ -36,6 +36,7 @@

#include "components/omnibox/browser/autocomplete_input.h"

#include "components/omnibox/browser/autocomplete_match.h"

#include "components/omnibox/browser/autocomplete_match_type.h"

+#include "components/omnibox/browser/omnibox_event_global_tracker.h"

#include "components/omnibox/browser/omnibox_field_trial.h"

#include "components/omnibox/browser/omnibox_log.h"

#include "components/omnibox/browser/search_provider.h"

@@ -237,6 +238,7 @@ void AutocompleteControllerAndroid::OnSuggestionSelected(

autocomplete_controller_->result());

autocomplete_controller_->AddProvidersInfo(&log.providers_info);

+ OmniboxEventGlobalTracker::GetInstance()->OnURLOpened(&log);

content::NotificationService::current()->Notify(

chrome::NOTIFICATION_OMNIBOX_OPENED_URL,

content::Source<Profile>(profile_),

« no previous file with comments | « no previous file | chrome/browser/metrics/omnibox_metrics_provider.h » ('j') | chrome/browser/metrics/omnibox_metrics_provider.cc » ('J')