Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/metrics/omnibox_metrics_provider.h

Issue 1278433002: Eliminate OmniboxMetricsProvider listening to notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_omnibox
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_OMNIBOX_METRICS_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_METRICS_OMNIBOX_METRICS_PROVIDER_H_
6 #define CHROME_BROWSER_METRICS_OMNIBOX_METRICS_PROVIDER_H_ 6 #define CHROME_BROWSER_METRICS_OMNIBOX_METRICS_PROVIDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "components/metrics/metrics_provider.h" 9 #include "components/metrics/metrics_provider.h"
10 #include "components/metrics/proto/chrome_user_metrics_extension.pb.h" 10 #include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
11 #include "content/public/browser/notification_observer.h" 11 #include "components/omnibox/browser/omnibox_event_global_tracker.h"
12 #include "content/public/browser/notification_registrar.h"
13 12
14 struct OmniboxLog; 13 struct OmniboxLog;
15 14
16 // OmniboxMetricsProvider is responsible for filling out the |omnibox_event| 15 // OmniboxMetricsProvider is responsible for filling out the |omnibox_event|
17 // section of the UMA proto. 16 // section of the UMA proto.
18 class OmniboxMetricsProvider : public metrics::MetricsProvider, 17 class OmniboxMetricsProvider : public metrics::MetricsProvider {
19 public content::NotificationObserver {
20 public: 18 public:
21 OmniboxMetricsProvider(); 19 OmniboxMetricsProvider();
22 ~OmniboxMetricsProvider() override; 20 ~OmniboxMetricsProvider() override;
23 21
24 // metrics::MetricsDataProvider: 22 // metrics::MetricsDataProvider:
25 void OnRecordingEnabled() override; 23 void OnRecordingEnabled() override;
26 void OnRecordingDisabled() override; 24 void OnRecordingDisabled() override;
27 void ProvideGeneralMetrics( 25 void ProvideGeneralMetrics(
28 metrics::ChromeUserMetricsExtension* uma_proto) override; 26 metrics::ChromeUserMetricsExtension* uma_proto) override;
29 27
30 private: 28 private:
31 // content::NotificationObserver: 29 // Called when a URL is opened from the Omnibox.
32 void Observe(int type, 30 void OnURLOpenedFromOmnibox(OmniboxLog* log);
33 const content::NotificationSource& source,
34 const content::NotificationDetails& details) override;
35 31
36 // Records the input text, available choices, and selected entry when the 32 // Records the input text, available choices, and selected entry when the
37 // user uses the Omnibox to open a URL. 33 // user uses the Omnibox to open a URL.
38 void RecordOmniboxOpenedURL(const OmniboxLog& log); 34 void RecordOmniboxOpenedURL(const OmniboxLog& log);
39 35
40 // Registar for receiving Omnibox event notifications. 36 // Subscription for receiving Omnibox event callbacks.
41 content::NotificationRegistrar registrar_; 37 scoped_ptr<base::CallbackList<void(OmniboxLog*)>::Subscription> subscription_;
42 38
43 // Saved cache of generated Omnibox event protos, to be copied into the UMA 39 // Saved cache of generated Omnibox event protos, to be copied into the UMA
44 // proto when ProvideGeneralMetrics() is called. 40 // proto when ProvideGeneralMetrics() is called.
45 metrics::ChromeUserMetricsExtension omnibox_events_cache; 41 metrics::ChromeUserMetricsExtension omnibox_events_cache;
46 42
47 DISALLOW_COPY_AND_ASSIGN(OmniboxMetricsProvider); 43 DISALLOW_COPY_AND_ASSIGN(OmniboxMetricsProvider);
48 }; 44 };
49 45
50 #endif // CHROME_BROWSER_METRICS_OMNIBOX_METRICS_PROVIDER_H_ 46 #endif // CHROME_BROWSER_METRICS_OMNIBOX_METRICS_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698