Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 127843005: Revert 241162 "Make clicking the restart bubble for crashed apps..." (Closed)

Created:
6 years, 11 months ago by koz (OOO until 15th September)
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 241162 "Make clicking the restart bubble for crashed apps..." This CL had the unintended side effect that Simulate Browser Restart no longer works. Also, experimentation suggests that the original bug it was intended to fix works without this change now. > Make clicking the restart bubble for crashed apps work. > > Previously AppLoadService listened for > NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING before dispatching the > onRestarted() event after a reload, but in the case of packaged apps, which use > non-persistent background pages, that notification will never get fired. This > is because reloading an app doesn't cause its background page to get loaded - > only a relevant event causes the page to be woken up. > > This patch fixes the issue by listening for NOTIFICATION_EXTENSION_LOADED > instead, which is always fired after a reload. It also determines whether an > extension is listening to an event by checking which events it has registered > for, not which ones it currently has a listener for, > NOTIFICATION_EXTENSION_LOADED is the notification that listeners get created > on, and so to avoid raciness we check registered events (ie: the persisted > list of events that an extension is interested in). > > BUG=327964 > > Review URL: https://codereview.chromium.org/93593003 TBR=koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M trunk/src/apps/app_load_service.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M trunk/src/apps/launcher.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
koz (OOO until 15th September)
6 years, 11 months ago (2014-01-09 00:03:17 UTC) #1
koz (OOO until 15th September)
6 years, 11 months ago (2014-01-09 00:03:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r243703.

Powered by Google App Engine
This is Rietveld 408576698