Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 127843002: Files.app: Adjust tab index for the save file diaog. (Closed)

Created:
6 years, 11 months ago by hirono
Modified:
6 years, 11 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Adjust tab index for the save file diaog. In the save file dialog, the file name input has a initial focus. Previously, the file name input has a tabindex=10, and when the focus goes back to the document, it moves to the file name input again because of the refocus method of Filemanager class. This CL change the tabindex of elements on the save-as dialog's footer and allow users to explorer all controls in Files.app. BUG=332051 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/resources/file_manager/main.html View 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hirono
PTAL the CL and give me permission to edit the "Tabindex in Files.app" document? Thanks!
6 years, 11 months ago (2014-01-08 09:13:50 UTC) #1
yoshiki
LGTM. I've added permittion, please modify the document as well.
6 years, 11 months ago (2014-01-09 02:30:16 UTC) #2
hirono
On 2014/01/09 02:30:16, yoshiki wrote: > LGTM. I've added permittion, please modify the document as ...
6 years, 11 months ago (2014-01-09 03:10:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/127843002/1
6 years, 11 months ago (2014-01-09 03:11:49 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:12:22 UTC) #5
Message was sent while issue was closed.
Change committed as 243859

Powered by Google App Engine
This is Rietveld 408576698