Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1278403006: SkPDF: clean up overuse of SK_SUPPORT_PDF (Closed)

Created:
5 years, 4 months ago by hal.canary
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: clean up overuse of SK_SUPPORT_PDF When possible use run-time checks (via SkDocument::CreatePDF) When PDF is disabled, do not compile tests/PDF*.cpp Committed: https://skia.googlesource.com/skia/+/2ccdb636e8618db77be8e05cdacd82c249c6898c

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2015-08-11 (Tuesday) 16:25:36 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -566 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tests/AnnotationTest.cpp View 4 chunks +2 lines, -3 lines 0 comments Download
M tests/CanvasTest.cpp View 1 2 chunks +6 lines, -3 lines 0 comments Download
D tests/DeflateWStream.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D tests/DocumentTest.cpp View 1 chunk +0 lines, -113 lines 0 comments Download
D tests/FlateTest.cpp View 1 chunk +0 lines, -117 lines 0 comments Download
A + tests/PDFDeflateWStreamTest.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
A + tests/PDFDocumentTest.cpp View 2 chunks +1 line, -2 lines 0 comments Download
A + tests/PDFFlateTest.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
A + tests/PDFGlyphsToUnicodeTest.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M tests/PDFInvalidBitmapTest.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M tests/PDFJpegEmbedTest.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
A + tests/PDFOpaqueSrcModeToSrcOverTest.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M tests/Test.h View 1 chunk +12 lines, -0 lines 0 comments Download
D tests/ToUnicodeTest.cpp View 1 chunk +0 lines, -183 lines 0 comments Download
D tests/skpdf_opaquesrcmodetosrcover.cpp View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hal.canary
Is this what you wanted?
5 years, 4 months ago (2015-08-11 18:52:09 UTC) #2
reed1
lgtm w/ nit https://codereview.chromium.org/1278403006/diff/1/tests/CanvasTest.cpp File tests/CanvasTest.cpp (right): https://codereview.chromium.org/1278403006/diff/1/tests/CanvasTest.cpp#newcode572 tests/CanvasTest.cpp:572: return; Should we assert that we ...
5 years, 4 months ago (2015-08-11 19:08:47 UTC) #3
hal.canary
https://codereview.chromium.org/1278403006/diff/1/tests/CanvasTest.cpp File tests/CanvasTest.cpp (right): https://codereview.chromium.org/1278403006/diff/1/tests/CanvasTest.cpp#newcode572 tests/CanvasTest.cpp:572: return; On 2015/08/11 19:08:47, reed1 wrote: > Should we ...
5 years, 4 months ago (2015-08-11 20:26:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278403006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278403006/20001
5 years, 4 months ago (2015-08-11 20:26:35 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 20:35:15 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2ccdb636e8618db77be8e05cdacd82c249c6898c

Powered by Google App Engine
This is Rietveld 408576698