Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: pkg/compiler/lib/src/resolution/access_semantics.dart

Issue 1278353003: Handle more unqualified SendSets (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/access_semantics.dart
diff --git a/pkg/compiler/lib/src/resolution/access_semantics.dart b/pkg/compiler/lib/src/resolution/access_semantics.dart
index 5abb0762b7d2fc8d56d2288dd8f85a0c312c791c..f73c983093e252cb84960ab6c2c8ba4a8bda9c5d 100644
--- a/pkg/compiler/lib/src/resolution/access_semantics.dart
+++ b/pkg/compiler/lib/src/resolution/access_semantics.dart
@@ -215,10 +215,6 @@ abstract class AccessSemantics {
/// [element] otherwise.
Element get setter => element;
- // TODO(johnniwinther): Make access semantics getter/setter specific.
- /// `true` if the [element] of this access is accessed statically.
- bool get isAccessedStatically => false;
-
const AccessSemantics._(this.kind);
String toString() {
@@ -253,8 +249,6 @@ class DynamicAccess extends AccessSemantics {
const DynamicAccess.ifNotNullProperty()
: super._(AccessKind.CONDITIONAL_DYNAMIC_PROPERTY);
-
- bool get isAccessedStatically => false;
}
class ConstantAccess extends AccessSemantics {
@@ -271,8 +265,6 @@ class ConstantAccess extends AccessSemantics {
ConstantAccess.dynamicTypeLiteral(this.constant)
: super._(AccessKind.DYNAMIC_TYPE_LITERAL);
-
- bool get isAccessedStatically => false;
}
class StaticAccess extends AccessSemantics {
@@ -352,18 +344,6 @@ class StaticAccess extends AccessSemantics {
StaticAccess.invalid(this.element)
: super._(AccessKind.INVALID);
-
- bool get isAccessedStatically {
- switch (kind) {
- case AccessKind.UNRESOLVED:
- case AccessKind.UNRESOLVED_SUPER:
- case AccessKind.INVALID:
- case AccessKind.TYPE_PARAMETER_TYPE_LITERAL:
- return false;
- default:
- return true;
- }
- }
}
class CompoundAccessSemantics extends AccessSemantics {
@@ -378,9 +358,6 @@ class CompoundAccessSemantics extends AccessSemantics {
Element get element => setter;
- // TODO(johnniwinther): Discriminate between access of the getter and setter.
- bool get isAccessedStatically => true;
-
String toString() {
StringBuffer sb = new StringBuffer();
sb.write('CompoundAccessSemantics[');
« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698