Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1278353002: Disable --global-var-shortcuts. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable --global-var-shortcuts. R=jkummerow@chromium.org BUG=chromium:517778 LOG=Y Committed: https://crrev.com/83c91aaf7bdec94d9862766cfd72b07917290052 Cr-Commit-Position: refs/heads/master@{#30084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-10 08:51:59 UTC) #1
Jakob Kummerow
LGTM, let's hope the bots have no objections.
5 years, 4 months ago (2015-08-10 08:54:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278353002/1
5 years, 4 months ago (2015-08-10 08:54:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 09:29:09 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 09:29:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83c91aaf7bdec94d9862766cfd72b07917290052
Cr-Commit-Position: refs/heads/master@{#30084}

Powered by Google App Engine
This is Rietveld 408576698