gpu/command_buffer/service/context_group_unittest.cc - Issue 1278333003: Fix crash caused by concurrent access to framebuffer_combo_complete_map_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/context_group_unittest.cc

Issue 1278333003: Fix crash caused by concurrent access to framebuffer_combo_complete_map_. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments; return unittesting of cache behaviour. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/deferred_gpu_command_service.cc ('K') | « gpu/command_buffer/service/context_group.cc ('k') | gpu/command_buffer/service/framebuffer_completeness_cache.h » ('j') | gpu/command_buffer/service/framebuffer_completeness_cache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/context_group_unittest.cc

diff --git a/gpu/command_buffer/service/context_group_unittest.cc b/gpu/command_buffer/service/context_group_unittest.cc

index 7c6d5c1c8bd73065051ba8ec1c9ac3f47c58a97d..cbb36f56bf22a0482d9b86bae77d9d7b0a54b5f3 100644

--- a/gpu/command_buffer/service/context_group_unittest.cc

+++ b/gpu/command_buffer/service/context_group_unittest.cc

@@ -41,7 +41,7 @@ class ContextGroupTest : public GpuServiceTest {

GpuServiceTest::SetUp();

decoder_.reset(new MockGLES2Decoder());

group_ = scoped_refptr<ContextGroup>(new ContextGroup(

- NULL, NULL, NULL, NULL, NULL, NULL, kBindGeneratesResource));

+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, kBindGeneratesResource));

}

scoped_ptr<MockGLES2Decoder> decoder_;