components/view_manager/gles2/command_buffer_driver.cc - Issue 1278333003: Fix crash caused by concurrent access to framebuffer_combo_complete_map_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/gles2/command_buffer_driver.cc

Issue 1278333003: Fix crash caused by concurrent access to framebuffer_combo_complete_map_. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments; return unittesting of cache behaviour. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/deferred_gpu_command_service.cc ('K') | « android_webview/browser/deferred_gpu_command_service.cc ('k') | content/common/gpu/gpu_channel_manager.h » ('j') | gpu/command_buffer/service/framebuffer_completeness_cache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/view_manager/gles2/command_buffer_driver.cc

diff --git a/components/view_manager/gles2/command_buffer_driver.cc b/components/view_manager/gles2/command_buffer_driver.cc

index 5a4ac83fb4943738eae6efe524845352e6ee23a7..82474429dd60def9bc02ec59ddb8a6323cee6e1d 100644

--- a/components/view_manager/gles2/command_buffer_driver.cc

+++ b/components/view_manager/gles2/command_buffer_driver.cc

@@ -117,8 +117,9 @@ bool CommandBufferDriver::DoInitialize(

scoped_refptr<gpu::gles2::ContextGroup> context_group =

new gpu::gles2::ContextGroup(

gpu_state_->mailbox_manager(), new GpuMemoryTracker,

- new gpu::gles2::ShaderTranslatorCache, nullptr, nullptr, nullptr,

- bind_generates_resource);

+ new gpu::gles2::ShaderTranslatorCache,

+ new gpu::gles2::FramebufferCompletenessCache, nullptr, nullptr,

+ nullptr, bind_generates_resource);

command_buffer_.reset(

new gpu::CommandBufferService(context_group->transfer_buffer_manager()));