Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2457)

Unified Diff: android_webview/browser/deferred_gpu_command_service.h

Issue 1278333003: Fix crash caused by concurrent access to framebuffer_combo_complete_map_. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments; return unittesting of cache behaviour. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/deferred_gpu_command_service.h
diff --git a/android_webview/browser/deferred_gpu_command_service.h b/android_webview/browser/deferred_gpu_command_service.h
index c7f230dd0249f355562e6480ea4bd196c41b5018..395fd681a537404b417230c649f068b5cf8a3e79 100644
--- a/android_webview/browser/deferred_gpu_command_service.h
+++ b/android_webview/browser/deferred_gpu_command_service.h
@@ -46,6 +46,8 @@ class DeferredGpuCommandService
bool UseVirtualizedGLContexts() override;
scoped_refptr<gpu::gles2::ShaderTranslatorCache> shader_translator_cache()
override;
+ scoped_refptr<gpu::gles2::FramebufferCompletenessCache>
+ framebuffer_completeness_cache() override;
Ken Russell (switch to Gerrit) 2015/08/20 00:04:10 The second line should be intended here. There are
Tobias Sargeant 2015/08/20 11:05:13 This is clang-format'ed, and it's also consistent
gpu::SyncPointManager* sync_point_manager() override;
void RunTasks();
@@ -76,6 +78,8 @@ class DeferredGpuCommandService
scoped_ptr<gpu::SyncPointManager> sync_point_manager_;
scoped_refptr<gpu::gles2::ShaderTranslatorCache> shader_translator_cache_;
+ scoped_refptr<gpu::gles2::FramebufferCompletenessCache>
+ framebuffer_completeness_cache_;
DISALLOW_COPY_AND_ASSIGN(DeferredGpuCommandService);
};

Powered by Google App Engine
This is Rietveld 408576698