Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: trunk/src/chrome/browser/signin/oauth2_token_service.cc

Issue 12782018: Revert 190531 "Get OAuth2TokenService working on Android." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/signin/oauth2_token_service.cc
===================================================================
--- trunk/src/chrome/browser/signin/oauth2_token_service.cc (revision 190557)
+++ trunk/src/chrome/browser/signin/oauth2_token_service.cc (working copy)
@@ -29,10 +29,6 @@
#include "google_apis/gaia/oauth2_access_token_consumer.h"
#include "google_apis/gaia/oauth2_access_token_fetcher.h"
-#if defined(OS_ANDROID)
-#include "chrome/browser/sync/profile_sync_service_android.h"
-#endif
-
namespace {
// Maximum number of retries in fetching an OAuth2 access token.
@@ -366,9 +362,9 @@
// static
void OAuth2TokenService::InformConsumer(
base::WeakPtr<OAuth2TokenService::RequestImpl> request,
- const GoogleServiceAuthError& error,
- const std::string& access_token,
- const base::Time& expiration_date) {
+ GoogleServiceAuthError error,
+ std::string access_token,
+ base::Time expiration_date) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
if (request)
@@ -382,7 +378,6 @@
scoped_ptr<RequestImpl> request(new RequestImpl(consumer));
-#if !defined(OS_ANDROID)
TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
if (!token_service || !token_service->HasOAuthLoginToken()) {
MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
@@ -393,7 +388,6 @@
base::Time()));
return request.PassAs<Request>();
}
-#endif
const CacheEntry* cache_entry = GetCacheEntry(scopes);
if (cache_entry && cache_entry->access_token.length()) {
@@ -406,17 +400,6 @@
return request.PassAs<Request>();
}
-#if defined(OS_ANDROID)
- DCHECK_EQ(scopes.size(), 1U);
- std::vector<std::string> scope_list(scopes.begin(), scopes.end());
- ProfileSyncServiceAndroid* sync_service =
- ProfileSyncServiceAndroid::GetProfileSyncServiceAndroid();
- sync_service->FetchOAuth2Token(
- scope_list.front(),
- base::Bind(&OAuth2TokenService::InformConsumer,
- request->AsWeakPtr()));
- return request.PassAs<Request>();
-#else
std::string refresh_token = token_service->GetOAuth2LoginRefreshToken();
if (!refresh_token.length()) {
MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
@@ -442,24 +425,8 @@
pending_fetchers_[fetch_parameters] = Fetcher::CreateAndStart(
profile_, getter_, refresh_token, scopes, request->AsWeakPtr());
return request.PassAs<Request>();
-#endif // defined(OS_ANDROID)
}
-void OAuth2TokenService::InvalidateToken(const ScopeSet& scopes,
- const std::string& invalid_token) {
- RemoveCacheEntry(scopes, invalid_token);
-
-#if defined(OS_ANDROID)
- DCHECK_EQ(scopes.size(), 1U);
- std::vector<std::string> scope_list(scopes.begin(), scopes.end());
- ProfileSyncServiceAndroid* sync_service =
- ProfileSyncServiceAndroid::GetProfileSyncServiceAndroid();
- sync_service->InvalidateOAuth2Token(
- scope_list.front(),
- invalid_token);
-#endif
-}
-
void OAuth2TokenService::OnFetchComplete(Fetcher* fetcher) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
@@ -515,19 +482,6 @@
return &token_iterator->second;
}
-bool OAuth2TokenService::RemoveCacheEntry(
- const OAuth2TokenService::ScopeSet& scopes,
- const std::string& token_to_remove) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
- TokenCache::iterator token_iterator = token_cache_.find(scopes);
- if (token_iterator == token_cache_.end() &&
- token_iterator->second.access_token == token_to_remove) {
- token_cache_.erase(token_iterator);
- return true;
- }
- return false;
-}
-
void OAuth2TokenService::RegisterCacheEntry(
const std::string& refresh_token,
const OAuth2TokenService::ScopeSet& scopes,
@@ -535,7 +489,6 @@
const base::Time& expiration_date) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
-#if !defined(OS_ANDROID)
// Only register OAuth2 access tokens for the refresh token held by
// TokenService.
TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
@@ -546,7 +499,6 @@
"Received a token with a refresh token not maintained by TokenService.";
return;
}
-#endif
CacheEntry& token = token_cache_[scopes];
token.access_token = access_token;

Powered by Google App Engine
This is Rietveld 408576698