Issue 12782018: Revert 190531 "Get OAuth2TokenService working on Android."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12782018: Revert 190531 "Get OAuth2TokenService working on Android." (Closed)

Created:
7 years, 9 months ago by hashimoto

Modified:
7 years, 9 months ago

Reviewers:
Patrick Dubroy

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 190531 "Get OAuth2TokenService working on Android." > Get OAuth2TokenService working on Android. > > In order to get OAuth tokens on Android, we have to call out to Java. This CL > makes it possible. It's not the ideal solution but works for now. > > BUG=222271 > > Review URL: https://codereview.chromium.org/12880014 TBR=dubroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190558

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -263 lines)			Patch
M	trunk/src/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java	View	5 chunks	+10 lines, -64 lines	0 comments	Download
M	trunk/src/chrome/browser/history/web_history_service.cc	View	5 chunks	+0 lines, -22 lines	0 comments	Download
M	trunk/src/chrome/browser/signin/oauth2_token_service.h	View	4 chunks	+3 lines, -17 lines	0 comments	Download
M	trunk/src/chrome/browser/signin/oauth2_token_service.cc	View	9 chunks	+3 lines, -51 lines	0 comments	Download
M	trunk/src/chrome/browser/signin/oauth2_token_service_unittest.cc	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/profile_sync_service_android.h	View	3 chunks	+0 lines, -34 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/profile_sync_service_android.cc	View	3 chunks	+0 lines, -58 lines	0 comments	Download
M	trunk/src/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

7 years, 9 months ago (2013-03-26 05:26:13 UTC) #3

Message was sent while issue was closed.

On 2013/03/26 05:24:27, hashimoto wrote:
> Committed patchset #1 manually as r190558.
Reverting 190531 to fix Andriod Tests buildbot failure
(http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...)

Expand Messages | Collapse Messages