Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: src/IceAssemblerX86BaseImpl.h

Issue 1278173009: Inline memove for small constant sizes and refactor memcpy and memset. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Simplify xtests and add flags for memory intrinsic optimization. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceAssemblerX86BaseImpl.h
diff --git a/src/IceAssemblerX86BaseImpl.h b/src/IceAssemblerX86BaseImpl.h
index f78575682cc52f16d87488d694244881dc9b7f68..9f97c75e1c7ca5d07b6a66c3f2faadb2ab93077d 100644
--- a/src/IceAssemblerX86BaseImpl.h
+++ b/src/IceAssemblerX86BaseImpl.h
@@ -3098,6 +3098,29 @@ void AssemblerX86Base<Machine>::xadd(Type Ty,
}
template <class Machine>
+void AssemblerX86Base<Machine>::xchg(Type Ty, typename Traits::GPRRegister reg0,
+ typename Traits::GPRRegister reg1) {
+ AssemblerBuffer::EnsureCapacity ensured(&Buffer);
+ if (Ty == IceType_i16)
+ emitOperandSizeOverride();
+ // Use short form if either register is EAX.
+ if (reg0 == Traits::Encoded_Reg_Accumulator) {
+ emitRexB(Ty, reg1);
+ emitUint8(0x90 + gprEncoding(reg1));
+ } else if (reg1 == Traits::Encoded_Reg_Accumulator) {
+ emitRexB(Ty, reg0);
+ emitUint8(0x90 + gprEncoding(reg0));
+ } else {
+ emitRexRB(Ty, reg0, reg1);
+ if (isByteSizedArithType(Ty))
+ emitUint8(0x86);
+ else
+ emitUint8(0x87);
+ emitRegisterOperand(gprEncoding(reg0), gprEncoding(reg1));
+ }
+}
+
+template <class Machine>
void AssemblerX86Base<Machine>::xchg(Type Ty,
const typename Traits::Address &addr,
typename Traits::GPRRegister reg) {

Powered by Google App Engine
This is Rietveld 408576698