src/IceTargetLoweringX8664Traits.h - Issue 1278173009: Inline memove for small constant sizes and refactor memcpy and memset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8664Traits.h

Issue 1278173009: Inline memove for small constant sizes and refactor memcpy and memset. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8664Traits.h

diff --git a/src/IceTargetLoweringX8664Traits.h b/src/IceTargetLoweringX8664Traits.h

index 4a1200415bc55cc2cb47782289e9212960facdc7..7cb85e0816ff22e99797e133b4ca041dd700face 100644

--- a/src/IceTargetLoweringX8664Traits.h

+++ b/src/IceTargetLoweringX8664Traits.h

@@ -456,6 +456,13 @@ template <> struct MachineTraits<TargetX8664> {

/// The number of different NOP instructions

static const uint32_t X86_NUM_NOP_VARIANTS = 5;

+ /// \name Limits for unrolling memory intrinsics.

+ /// @{

+ static constexpr uint32_t MEMCPY_UNROLL_LIMIT = 8;

+ static constexpr uint32_t MEMMOVE_UNROLL_LIMIT = 8;

+ static constexpr uint32_t MEMSET_UNROLL_LIMIT = 16;

+ /// @}

/// Value is in bytes. Return Value adjusted to the next highest multiple

/// of the stack alignment.

static uint32_t applyStackAlignment(uint32_t Value) {

« no previous file with comments | « src/IceTargetLoweringX8632Traits.h ('k') | src/IceTargetLoweringX86Base.h » ('j') | no next file with comments »