Inline memove for small constant sizes and refactor memcpy and memset.

pydir/crosstest.py

 #!/usr/bin/env python2
 
 import argparse
 import os
 import subprocess
 import sys
 import tempfile
 
 import targets
 from utils import shellcmd
@@ skipping 75 matching lines @@
                                 ' Default "%(default)s".')
     argparser.add_argument('--crosstest-bitcode', required=False,
                            default=1, type=int,
                            help='Compile non-subzero crosstest object file ' +
                            'from the same bitcode as the subzero object. ' +
                            'If 0, then compile it straight from source.' +
                            ' Default %(default)d.')
     argparser.add_argument('--filetype', default='obj', dest='filetype',
                            choices=['obj', 'asm', 'iasm'],
                            help='Output file type.  Default %(default)s.')
+    argparser.add_argument('--sz', required=False, default='',

[Jim Stichnoth, 2015/08/20 16:57:04]

This should be made to allow multiple --sz arguments, like in szbuild.py:

  add_argument('--sz', dest='sz_args', action='append', default=[], help='...')

then add the arg array appropriately in the shellcmd.

[ascull, 2015/08/20 18:41:56]

Done.

+                           help='Extra arguments to pass to pnacl-sz.')
     args = argparser.parse_args()
 
     nacl_root = FindBaseNaCl()
     bindir = ('{root}/toolchain/linux_x86/pnacl_newlib_raw/bin'
               .format(root=nacl_root))
     target_info = arch_map[args.target]
     triple = target_info.triple
     if args.sandbox:
         triple = targets.ConvertTripleToNaCl(triple)
     llc_flags = target_info.llc_flags + arch_llc_flags_extra[args.target]
@@ skipping 20 matching lines @@
                       '-pnacl-abi-simplify-preopt',
                       '-pnacl-abi-simplify-postopt',
                       '-pnaclabi-allow-debug-metadata',
                       bitcode_nonfinal, '-S', '-o', bitcode])
 
         base_sz = '{base}.{key}'.format(base=base, key=key)
         asm_sz = os.path.join(args.dir, base_sz + '.sz.s')
         obj_sz = os.path.join(args.dir, base_sz + '.sz.o')
         obj_llc = os.path.join(args.dir, base_sz + '.llc.o')
         shellcmd(['{path}/pnacl-sz'.format(path=os.path.dirname(mypath)),
+                  args.sz,
                   '-O' + args.optlevel,
                   '-mattr=' + args.attr,
                   '--target=' + args.target,
                   '--sandbox=' + str(args.sandbox),
                   '--prefix=' + args.prefix,
                   '-allow-uninitialized-globals',
                   '-externalize',
                   '-filetype=' + args.filetype,
                   '-o=' + (obj_sz if args.filetype == 'obj' else asm_sz),
                   bitcode] + arch_sz_flags[args.target])
@@ skipping 41 matching lines @@
                       if args.sandbox else
                       ['-g', '-target=' + triple,
                        '-lm', '-lpthread',
                        '-Wl,--defsym=__Sz_AbsoluteZero=0'] +
                       target_info.cross_headers)
     shellcmd([compiler, args.driver] + objs +
              ['-o', os.path.join(args.dir, args.output)] + sb_native_args)
 
 if __name__ == '__main__':
     main()