Inline memove for small constant sizes and refactor memcpy and memset.

unittest/AssemblerX8664/Locked.cpp

 //===- subzero/unittest/AssemblerX8664/Locked.cpp -------------------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 #include "AssemblerX8664/TestUtil.h"
 
@@ skipping 67 matching lines @@
   TestImpl(r10);
   TestImpl(r11);
   TestImpl(r12);
   TestImpl(r13);
   TestImpl(r14);
   TestImpl(r15);
 
 #undef TestImpl
 #undef TestImplSize
 #undef TestImplAddrReg
+
+#define TestImplRegReg(Reg0, Value0, Reg1, Value1, Size)                       \
+  do {                                                                         \
+    static constexpr char TestString[] =                                       \
+        "(" #Reg0 "," #Value0 ", " #Reg1 ", " #Value1 ", " #Size ")";          \
+    const uint32_t V0 = (Value0)&Mask##Size;                                   \
+    const uint32_t V1 = (Value1)&Mask##Size;                                   \
+                                                                               \
+    __ mov(IceType_i##Size, Encoded_GPR_##Reg0(), Immediate(Value0));          \
+    __ mov(IceType_i##Size, Encoded_GPR_##Reg1(), Immediate(Value1));          \
+    __ xchg(IceType_i##Size, Encoded_GPR_##Reg0(), Encoded_GPR_##Reg1());      \
+    __ And(IceType_i32, Encoded_GPR_##Reg0(), Immediate(Mask##Size));          \
+    __ And(IceType_i32, Encoded_GPR_##Reg1(), Immediate(Mask##Size));          \
+                                                                               \
+    AssembledTest test = assemble();                                           \
+    test.run();                                                                \
+                                                                               \
+    ASSERT_EQ(V0, test.Reg1()) << TestString;                                  \
+    ASSERT_EQ(V1, test.Reg0()) << TestString;                                  \
+    reset();                                                                   \
+  } while (0)
+
+#define TestImplSize(Reg0, Reg1, Size)                                         \
+  do {                                                                         \
+    TestImplRegReg(Reg0, 0xa2b34567, Reg1, 0x0507ddee, Size);                  \
+  } while (0)
+
+#define TestImpl(Reg0, Reg1)                                                   \
+  do {                                                                         \
+    TestImplSize(Reg0, Reg1, 8);                                               \
+    TestImplSize(Reg0, Reg1, 16);                                              \
+    TestImplSize(Reg0, Reg1, 32);                                              \

[jvoung (off chromium), 2015/08/18 17:18:22]

Does size 64 work?

[ascull, 2015/08/18 18:38:01]

No. I tried it and there were a lot of build errors I didn't understand.

JPP: do you know anything about this?

+  } while (0)
+
+  TestImpl(r1, r8);

[jvoung (off chromium), 2015/08/18 17:18:22]

Maybe throw in eax/rax too, if that has a special encoding.

[ascull, 2015/08/18 18:38:01]

Done.

[John, 2015/08/18 18:51:39]

r1 == rax

Sorry for making this so confusing.

[ascull, 2015/08/18 19:03:10]

Ok, I've fixed the fix ;)

+  TestImpl(r2, r10);
+  TestImpl(r3, r11);
+  TestImpl(r4, r12);
+  TestImpl(r5, r13);
+  TestImpl(r6, r14);
+  TestImpl(r7, r15);
+
+#undef TestImpl
+#undef TestImplSize
+#undef TestImplAddrReg

[jvoung (off chromium), 2015/08/18 17:18:22]

undef TestImplRegReg

[ascull, 2015/08/18 18:38:01]

Done.

 }
 
 TEST_F(AssemblerX8664Test, Xadd) {
   static constexpr bool NotLocked = false;
   static constexpr bool Locked = true;
 
   static constexpr uint32_t Mask8 = 0x000000FF;
   static constexpr uint32_t Mask16 = 0x0000FFFF;
   static constexpr uint32_t Mask32 = 0xFFFFFFFF;
 
@@ skipping 342 matching lines @@
     ASSERT_TRUE(verifyBytes<ByteCountLocked32>(
         codeBytes(), 0xF0, 0x44, 0x0F, 0xB1, 0x35, 0x00, 0xFF, 0x01, 0x00));
     reset();
   }
 }
 
 } // end of anonymous namespace
 } // end of namespace Test
 } // end of namespace X8664
 } // end of namespace Ice