Inline memove for small constant sizes and refactor memcpy and memset.

Makefile.standalone

 # The following variables will likely need to be modified, depending on where
 # and how you built LLVM & Clang. They can be overridden in a command-line
 # invocation of make, like:
 #
 #   make LLVM_SRC_PATH=<path> LIBCXX_INSTALL_PATH=<path> CLANG_PATH=<path> \
 #        PNACL_BIN_PATH=<path> ...
 #
 
 # LLVM_SRC_PATH is the path to the root of the checked out source code. This
 # directory should contain the configure script, the include/ and lib/
@@ skipping 343 matching lines @@
           -i x8632,sandbox,sse4.1,Om1 \
           -i arm32,native,neon,simple_loop \
           -i arm32,native,neon,mem_intrin \
           -i arm32,native,neon,test_bitmanip \
           -i arm32,native,neon,test_stacksave \
           -i arm32,native,neon,test_strengthreduce
         PNACL_BIN_PATH=$(PNACL_BIN_PATH) \
         $(LLVM_SRC_PATH)/utils/lit/lit.py -sv crosstest/Output
 endif
 
+ifdef DEBUG
 check-unit: $(OBJDIR)/run_unittests
         $(OBJDIR)/run_unittests
+else
+check-unit:
+        @echo "Run with DEBUG=1 lest your machine perish."

[Jim Stichnoth, 2015/08/18 17:11:28]

Cool.

Maybe add "check-unit" to the echo string, so that "make check" output is more
understandable?

[ascull, 2015/08/18 18:38:01]

Done.

[John, 2015/08/18 18:51:39]

I have something similar in a patch -- which I reproduce here:
UNITTEST_SRCS = \
        BitcodeMunge.cpp \
        IceELFSectionTest.cpp \
        IceParseInstsTest.cpp

# PATCH-BEGIN
# The X86 assembler tests take too long to compile. Given how infrequently the
# assembler will change, we disable them. Furthermore, they are completely
# disabled in non-DEBUG builds. The compiler goes bananas with so many
# optimization oportunities, and eventually freezes the entire machine.
ifdef CHECK_X86_ASM
ifndef DEBUG
$(info X86 Assembler tests not available in non-debug build.)
else
UNITTEST_SRCS += AssemblerX8632/LowLevel.cpp \
        AssemblerX8632/DataMov.cpp \
        AssemblerX8632/Locked.cpp \
        AssemblerX8632/GPRArith.cpp \
        AssemblerX8632/XmmArith.cpp \
        AssemblerX8632/ControlFlow.cpp \
        AssemblerX8632/Other.cpp \
        AssemblerX8632/X87.cpp \
        AssemblerX8664/LowLevel.cpp \
        AssemblerX8664/DataMov.cpp \
        AssemblerX8664/Locked.cpp \
        AssemblerX8664/GPRArith.cpp \
        AssemblerX8664/XmmArith.cpp \
        AssemblerX8664/ControlFlow.cpp \
        AssemblerX8664/Other.cpp
endif
endif
# PATCH-END

UNITTEST_OBJS = $(patsubst %.cpp, $(OBJDIR)/unittest/%.o, $(UNITTEST_SRCS))

[ascull, 2015/08/18 19:03:10]

We can merge to yours when the time comes. Mine is a bit more aggressive.

+endif
 
 check: check-lit check-unit check-xtest
 
 FORMAT_BLACKLIST =
 # Add one of the following lines for each source file to ignore.
 FORMAT_BLACKLIST += ! -name IceParseInstsTest.cpp
 FORMAT_BLACKLIST += ! -name IceParseTypesTest.cpp
 format:
         $(CLANG_FORMAT_PATH)/clang-format -style=LLVM -i \
         `find . -regex '.*\.\(c\|h\|cpp\)' $(FORMAT_BLACKLIST)`
@@ skipping 11 matching lines @@
 
 docs:
         doxygen Doxyfile
         @echo See file://`pwd`/docs/html/index.html
 
 clean:
         rm -rf pnacl-sz *.o $(OBJDIR) $(SB_OBJDIR) build/pnacl-sz.bloat.json
 
 clean-all: clean
         rm -rf build/ docs/