Inline memove for small constant sizes and refactor memcpy and memset.

src/IceAssemblerX86Base.h

 //===- subzero/src/IceAssemblerX86Base.h - base x86 assembler -*- C++ -*---===//
 //
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Modified by the Subzero authors.
 //
 //===----------------------------------------------------------------------===//
 //
@@ skipping 812 matching lines @@
   void jmp(const ConstantRelocatable *label); // not testable.
 
   void mfence();
 
   void lock();
   void cmpxchg(Type Ty, const typename Traits::Address &address,
                typename Traits::GPRRegister reg, bool Locked);
   void cmpxchg8b(const typename Traits::Address &address, bool Locked);
   void xadd(Type Ty, const typename Traits::Address &address,
             typename Traits::GPRRegister reg, bool Locked);
+  void xchg(Type Ty, typename Traits::GPRRegister reg0,

[John, 2015/08/12 17:44:57]

Can you add tests for this new xchg instruction? They live in

unittest/AssemblerX8632/Locked.cpp

and

unittest/AssemblerX8664/Locked.cpp

to run the tests you need to

make CHECK_X86_ASM=1 check.

[ascull, 2015/08/17 22:18:52]

I have put some tests. I don't know how extensive you want them to be. I also
don't use this instruction any more so should it stay or be removed?

+            typename Traits::GPRRegister reg1);
   void xchg(Type Ty, const typename Traits::Address &address,
             typename Traits::GPRRegister reg);
 
   /// \name Intel Architecture Code Analyzer markers.
   /// @{
   void iaca_start();
   void iaca_end();
   /// @}
 
   void emitSegmentOverride(uint8_t prefix);
@@ skipping 202 matching lines @@
   emitUint8(0x66);
 }
 
 } // end of namespace X86Internal
 
 } // end of namespace Ice
 
 #include "IceAssemblerX86BaseImpl.h"
 
 #endif // SUBZERO_SRC_ICEASSEMBLERX86BASE_H