Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1278173006: Default to 1 when --force-device-scale-factor has an invalid value. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
msw, oshima
CC:
chromium-reviews, jshin+watch_chromium.org, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Default to 1 when --force-device-scale-factor has an invalid value. Currently, the scaling factor may end up as 0, causing a divide by 0. Also add warnings to base::StringToFoo(). BUG=517944 Committed: https://crrev.com/62d4c69ec6bfaff365d9b240c1519802ddd245ab Cr-Commit-Position: refs/heads/master@{#342505}

Patch Set 1 #

Patch Set 2 : with unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M base/strings/string_number_conversions.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/gfx/display.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/display_unittest.cc View 1 1 chunk +27 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
msw: I'd ask oshima, but he's OOO.
5 years, 4 months ago (2015-08-07 22:15:43 UTC) #2
Lei Zhang
And now with unit test.
5 years, 4 months ago (2015-08-07 22:25:01 UTC) #3
oshima
lgtm
5 years, 4 months ago (2015-08-08 00:12:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278173006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278173006/20001
5 years, 4 months ago (2015-08-08 00:20:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-08 02:27:13 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 02:27:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62d4c69ec6bfaff365d9b240c1519802ddd245ab
Cr-Commit-Position: refs/heads/master@{#342505}

Powered by Google App Engine
This is Rietveld 408576698