Issue 1278153002: Devtools: fix MIME type inferrence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1278153002: Devtools: fix MIME type inferrence. (Closed)

Created:
5 years, 4 months ago by ppi

Modified:
5 years, 4 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Devtools: fix MIME type inferrence. This broke when we moved to use temporary files for gzipped content, hence losing the file extension. This patch fixes the mime type inferrence to use the original path and adds a test. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6596c152c7d40ebfa021dd9726ad8873b83c0d84

Patch Set 1 #

Patch Set 2 : Address Ben's comments. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -2 lines)			Patch
	M	mojo/devtools/common/devtoolslib/http_server.py	View		3 chunks	+7 lines, -2 lines	0 comments	Download
	M	mojo/devtools/common/devtoolslib/http_server_unittest.py	View	1	3 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 4 months ago (2015-08-07 14:07:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6596c152c7d40ebfa021dd9726ad8873b83c0d84 (presubmit successful).

Expand Messages | Collapse Messages