Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: Source/core/css/StylePropertySerializer.h

Issue 1278143002: Oilpan: tidy StylePropertySerializer's handling of GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StylePropertySerializer.h
diff --git a/Source/core/css/StylePropertySerializer.h b/Source/core/css/StylePropertySerializer.h
index 2a2bfd6a93080b3da55b66a865f46b9f8f5c5b18..3d209d42a5fd98359d53ac1d65ccc247b8ff1760 100644
--- a/Source/core/css/StylePropertySerializer.h
+++ b/Source/core/css/StylePropertySerializer.h
@@ -34,6 +34,7 @@ class StylePropertySet;
class StylePropertyShorthand;
class StylePropertySerializer {
+ STACK_ALLOCATED();
public:
explicit StylePropertySerializer(const StylePropertySet&);
@@ -88,7 +89,8 @@ private:
bool m_isInherited;
};
- class StylePropertySetForSerializer {
+ class StylePropertySetForSerializer final {
+ DISALLOW_ALLOCATION();
public:
explicit StylePropertySetForSerializer(const StylePropertySet&);
@@ -101,11 +103,13 @@ private:
bool isPropertyImplicit(CSSPropertyID) const;
bool propertyIsImportant(CSSPropertyID) const;
+ DECLARE_TRACE();
+
private:
bool hasExpandedAllProperty() const { return hasAllProperty() && m_needToExpandAll; }
bool hasAllProperty() const { return m_allIndex != -1; }
- const StylePropertySet& m_propertySet;
+ RawPtrWillBeMember<const StylePropertySet> m_propertySet;
int m_allIndex;
BitArray<numCSSProperties> m_longhandPropertyUsed;
bool m_needToExpandAll;
@@ -116,4 +120,4 @@ private:
} // namespace blink
-#endif
+#endif // StylePropertySerializer_h
« no previous file with comments | « no previous file | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698