Source/core/paint/DeprecatedPaintLayer.cpp - Issue 1278113003: Calculate correct clip foregroundBound and backgroundBound

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1278113003: Calculate correct clip foregroundBound and backgroundBound (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add layout test and fix background Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/sub-pixel/clip-zoomed-rect-box-with-overflow-expected.html ('k') | Source/core/paint/DeprecatedPaintLayerClipper.cpp » ('j') | Source/core/paint/DeprecatedPaintLayerClipper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/DeprecatedPaintLayer.cpp

diff --git a/Source/core/paint/DeprecatedPaintLayer.cpp b/Source/core/paint/DeprecatedPaintLayer.cpp

index 8f81438d191b53a8bd1b75dbbeec10a6ec70eaf8..b204f95d5cf7aae4e413fc2daca0057809f2205a 100644

--- a/Source/core/paint/DeprecatedPaintLayer.cpp

+++ b/Source/core/paint/DeprecatedPaintLayer.cpp

@@ -1441,7 +1441,7 @@ void DeprecatedPaintLayer::collectFragments(DeprecatedPaintLayerFragments& fragm

ancestorClipRect.intersect(dirtyRect);

}

- const LayoutSize subPixelAccumulationIfNeeded = compositingState() == PaintsIntoOwnBacking ? LayoutSize() : subPixelAccumulation;

+ const LayoutSize subPixelAccumulationIfNeeded = offsetFromRoot ? subPixelAccumulation : LayoutSize();

for (size_t i = 0; i < fragments.size(); ++i) {

DeprecatedPaintLayerFragment& fragment = fragments.at(i);