Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: Source/core/css/parser/CSSParserObserverWrapper.h

Issue 1278103002: Oilpan: tidy up some inter-stack object references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/parser/CSSSupportsParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSParserObserverWrapper.h
diff --git a/Source/core/css/parser/CSSParserObserverWrapper.h b/Source/core/css/parser/CSSParserObserverWrapper.h
index 1aff9fcdb42e4478047de7b545a31f211f87cbcd..105a844652cd90374c469c075aaedffa4f30c49c 100644
--- a/Source/core/css/parser/CSSParserObserverWrapper.h
+++ b/Source/core/css/parser/CSSParserObserverWrapper.h
@@ -11,8 +11,8 @@ namespace blink {
class CSSParserObserverWrapper {
public:
- CSSParserObserverWrapper(CSSParserObserver& observer)
- : m_observer(observer)
+ explicit CSSParserObserverWrapper(CSSParserObserver& observer)
+ : m_observer(observer)
{ }
unsigned startOffset(const CSSParserTokenRange&);
@@ -36,6 +36,9 @@ public:
}
private:
+ // Oilpan: CSSParserObserver is stack allocated and stack scanning will
+ // separately locate it.
+ GC_PLUGIN_IGNORE("509911")
CSSParserObserver& m_observer;
haraken 2015/08/07 08:17:56 Shall we change this to a RawPtrWillBeMember? (I t
sof 2015/08/07 08:20:20 We can't - it's currently marked as STACK_ALLOCATE
haraken 2015/08/07 08:27:38 ah, understand. Maybe it would make more sense to
sof 2015/08/07 09:11:07 Stack references held by stack "hosts" are recogni
Vector<unsigned> m_tokenOffsets;
CSSParserToken* m_firstParserToken;
« no previous file with comments | « no previous file | Source/core/css/parser/CSSSupportsParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698