Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/modules/webaudio/AudioParam.h

Issue 1278103002: Oilpan: tidy up some inter-stack object references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use STACK_ALLOCATED() more often Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/crypto/CryptoKey.cpp ('k') | public/platform/WebCryptoKeyAlgorithmParams.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // dies. 51 // dies.
52 class AudioParamHandler final : public ThreadSafeRefCounted<AudioParamHandler>, public AudioSummingJunction { 52 class AudioParamHandler final : public ThreadSafeRefCounted<AudioParamHandler>, public AudioSummingJunction {
53 public: 53 public:
54 static const double DefaultSmoothingConstant; 54 static const double DefaultSmoothingConstant;
55 static const double SnapThreshold; 55 static const double SnapThreshold;
56 56
57 static PassRefPtr<AudioParamHandler> create(AbstractAudioContext& context, d ouble defaultValue) 57 static PassRefPtr<AudioParamHandler> create(AbstractAudioContext& context, d ouble defaultValue)
58 { 58 {
59 return adoptRef(new AudioParamHandler(context, defaultValue)); 59 return adoptRef(new AudioParamHandler(context, defaultValue));
60 } 60 }
61 DECLARE_TRACE(); 61
62 // This should be used only in audio rendering thread. 62 // This should be used only in audio rendering thread.
63 AbstractAudioContext* context() const; 63 AbstractAudioContext* context() const;
64 64
65 // AudioSummingJunction 65 // AudioSummingJunction
66 void didUpdate() override { } 66 void didUpdate() override { }
67 67
68 AudioParamTimeline& timeline() { return m_timeline; } 68 AudioParamTimeline& timeline() { return m_timeline; }
69 69
70 // Intrinsic value. 70 // Intrinsic value.
71 float value(); 71 float value();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 double m_value; 114 double m_value;
115 double m_defaultValue; 115 double m_defaultValue;
116 116
117 // Smoothing (de-zippering) 117 // Smoothing (de-zippering)
118 double m_smoothedValue; 118 double m_smoothedValue;
119 119
120 AudioParamTimeline m_timeline; 120 AudioParamTimeline m_timeline;
121 121
122 // We can't make this Persistent because of a reference cycle. It's safe to 122 // We can't make this Persistent because of a reference cycle. It's safe to
123 // access this field only when we're rendering audio. 123 // access this field only when we're rendering audio.
124 GC_PLUGIN_IGNORE("509911")
124 AbstractAudioContext& m_context; 125 AbstractAudioContext& m_context;
125 }; 126 };
126 127
127 // AudioParam class represents web-exposed AudioParam interface. 128 // AudioParam class represents web-exposed AudioParam interface.
128 class AudioParam final : public GarbageCollectedFinalized<AudioParam>, public Sc riptWrappable { 129 class AudioParam final : public GarbageCollectedFinalized<AudioParam>, public Sc riptWrappable {
129 DEFINE_WRAPPERTYPEINFO(); 130 DEFINE_WRAPPERTYPEINFO();
130 public: 131 public:
131 static AudioParam* create(AbstractAudioContext&, double defaultValue); 132 static AudioParam* create(AbstractAudioContext&, double defaultValue);
132 DECLARE_TRACE(); 133 DECLARE_TRACE();
133 // |handler| always returns a valid object. 134 // |handler| always returns a valid object.
(...skipping 14 matching lines...) Expand all
148 private: 149 private:
149 AudioParam(AbstractAudioContext&, double defaultValue); 150 AudioParam(AbstractAudioContext&, double defaultValue);
150 151
151 RefPtr<AudioParamHandler> m_handler; 152 RefPtr<AudioParamHandler> m_handler;
152 Member<AbstractAudioContext> m_context; 153 Member<AbstractAudioContext> m_context;
153 }; 154 };
154 155
155 } // namespace blink 156 } // namespace blink
156 157
157 #endif // AudioParam_h 158 #endif // AudioParam_h
OLDNEW
« no previous file with comments | « Source/modules/crypto/CryptoKey.cpp ('k') | public/platform/WebCryptoKeyAlgorithmParams.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698