Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 12781007: Merge 185528 "sync: Drop fully datatype throttled sync jobs rath..." (Closed)

Created:
7 years, 9 months ago by tim (not reviewing)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin
Visibility:
Public.

Description

Merge 185528 "sync: Drop fully datatype throttled sync jobs rath..." > sync: Drop fully datatype throttled sync jobs rather than saving them. > > This avoids a bug where we loop infinitely with calls to RestartWaiting > with a zero WaitInterval length, which happens in part because we don't > honour ThrottledDatatypeTracker unthrottle times and rely on seperate > exponential backoff treatment. > > BUG=177659 > > > Review URL: https://chromiumcodereview.appspot.com/12386012 TBR=tim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M sync/engine/sync_scheduler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler_whitebox_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tim (not reviewing)
7 years, 9 months ago (2013-03-12 17:55:11 UTC) #1
tim (not reviewing)
7 years, 9 months ago (2013-03-12 17:55:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r187611.

Powered by Google App Engine
This is Rietveld 408576698