chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm - Issue 1278073002: Mac: Use activateIgnoringOtherApps instead of SetFrontProcessWithOptions to focus app windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

Issue 1278073002: Mac: Use activateIgnoringOtherApps instead of SetFrontProcessWithOptions to focus app windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

index c7df9af4eea52c417a89b15f0deff66401366477..718e7221ad7a23ca219536a8fde0dc29914f5bf1 100644

--- a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

@@ -497,7 +497,9 @@ void NativeAppWindowCocoa::Show() {

}

last_activate_ = now;

- [BrowserWindowUtils activateWindowForController:window_controller_];

+ [window() makeKeyAndOrderFront:nil];

+ [NSApp activateIgnoringOtherApps:YES];

}

void NativeAppWindowCocoa::ShowInactive() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »