Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1278043003: Move AAFillRect into CPP for templatization (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move AAFillRect into CPP for templatization BUG=skia: Committed: https://skia.googlesource.com/skia/+/37eb184e26a96f5c3593b7c2cf29f1a197eb5ac9

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -260 lines) Patch
M src/gpu/batches/GrAAFillRectBatch.h View 1 chunk +8 lines, -73 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 3 chunks +252 lines, -172 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Dependent Patchsets:

Issue 1290763002 Patch 1
Issue 1290763002 Patch 20001
Issue 1290763002 Patch 40001

Messages

Total messages: 6 (2 generated)
joshualitt
I'm open to other ways to do this. ptal
5 years, 4 months ago (2015-08-11 21:12:03 UTC) #2
bsalomon
lgtm
5 years, 4 months ago (2015-08-11 21:55:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278043003/20001
5 years, 4 months ago (2015-08-12 13:29:49 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 13:37:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/37eb184e26a96f5c3593b7c2cf29f1a197eb5ac9

Powered by Google App Engine
This is Rietveld 408576698