tests for keyword/identifier replacementOffset - asserts fixes #23906 and fixes #23947

pkg/analysis_server/test/services/completion/keyword_contributor_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.dart.keyword;
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/keyword_contributor.dart';
 import 'package:analyzer/src/generated/scanner.dart';
@@ skipping 823 matching lines @@
   }
 
   test_import_deferred_as4() {
     addTestSource('import "foo" d^');
     expect(computeFast(), isTrue);
     assertSuggestKeywords([Keyword.AS],
         pseudoKeywords: ['deferred as', 'show', 'hide'],
         relevance: DART_RELEVANCE_HIGH);
   }
 
+  test_import_deferred_as5() {
+    addTestSource('import "foo" sh^ import "bar"; import "baz";');
+    expect(computeFast(), isTrue);
+    assertSuggestKeywords([Keyword.AS],
+        pseudoKeywords: ['deferred as', 'show', 'hide'],
+        relevance: DART_RELEVANCE_HIGH);
+  }
+
   test_import_deferred_not() {
     addTestSource('import "foo" as foo ^;');
     expect(computeFast(), isTrue);
     assertSuggestKeywords([],
         pseudoKeywords: ['show', 'hide'], relevance: DART_RELEVANCE_HIGH);
   }
 
+  test_import_deferred_partial() {
+    addTestSource('import "package:foo/foo.dart" def^ as foo;');
+    expect(computeFast(), isTrue);
+    assertSuggestKeywords([Keyword.DEFERRED], relevance: DART_RELEVANCE_HIGH);
+    expect(request.replacementOffset, 30);
+    expect(request.replacementLength, 3);
+  }
+
   test_import_incomplete() {
     addTestSource('import "^"');
     expect(computeFast(), isTrue);
     assertNoSuggestions();
     assertSuggestKeywords([]);

[Brian Wilkerson, 2015/08/12 13:59:25]

I would have expected that 'assertNoSuggestions()' included keyword suggestions.

[danrubel, 2015/08/15 19:17:16]

Yup. That 2nd line is unnecessary. Removed.

   }
 
+  test_import_partial() {
+    addTestSource('imp^ import "package:foo/foo.dart"; import "bar.dart";');
+    expect(computeFast(), isTrue);
+    // TODO(danrubel) should not suggest declaration keywords

[Brian Wilkerson, 2015/08/12 13:59:25]

I'd rather see a test that is correct that is marked as 'fail' than a test with
a TODO to make it correct. I think it will be easier for us to discover later
that there's work to be done.

[danrubel, 2015/08/15 19:17:17]

Fair enough. Added.

+    assertSuggestKeywords(DIRECTIVE_DECLARATION_AND_LIBRARY_KEYWORDS,
+        relevance: DART_RELEVANCE_HIGH);
+    expect(request.replacementOffset, 0);
+    expect(request.replacementLength, 3);
+  }
+
+  test_import_partial2() {
+    addTestSource('^imp import "package:foo/foo.dart";');
+    expect(computeFast(), isTrue);
+    // TODO(danrubel) should not suggest declaration keywords
+    assertSuggestKeywords(DIRECTIVE_DECLARATION_AND_LIBRARY_KEYWORDS,
+        relevance: DART_RELEVANCE_HIGH);
+    expect(request.replacementOffset, 0);
+    expect(request.replacementLength, 3);
+  }
+
+  test_import_partial3() {
+    addTestSource(' ^imp import "package:foo/foo.dart"; import "bar.dart";');
+    expect(computeFast(), isTrue);
+    // TODO(danrubel) should not suggest declaration keywords
+    assertSuggestKeywords(DIRECTIVE_DECLARATION_AND_LIBRARY_KEYWORDS,
+        relevance: DART_RELEVANCE_HIGH);
+    expect(request.replacementOffset, 1);
+    expect(request.replacementLength, 3);
+  }
+
+  test_import_partial4() {
+    addTestSource('^ imp import "package:foo/foo.dart";');
+    expect(computeFast(), isTrue);
+    // TODO(danrubel) should not suggest declaration keywords
+    assertSuggestKeywords(DIRECTIVE_DECLARATION_AND_LIBRARY_KEYWORDS,
+        relevance: DART_RELEVANCE_HIGH);
+    expect(request.replacementOffset, 0);
+    expect(request.replacementLength, 0);
+  }
+
+  test_import_partial5() {
+    addTestSource('library libA; imp^ import "package:foo/foo.dart";');
+    expect(computeFast(), isTrue);
+    // TODO(danrubel) should not suggest declaration keywords
+    assertSuggestKeywords(DIRECTIVE_AND_DECLARATION_KEYWORDS,
+        relevance: DART_RELEVANCE_HIGH);
+    expect(request.replacementOffset, 14);
+    expect(request.replacementLength, 3);
+  }
+
+  test_import_partial6() {
+    addTestSource(
+        'library bar; import "zoo.dart"; imp^ import "package:foo/foo.dart";');
+    expect(computeFast(), isTrue);
+    // TODO(danrubel) should not suggest declaration keywords
+    assertSuggestKeywords(DIRECTIVE_AND_DECLARATION_KEYWORDS,
+        relevance: DART_RELEVANCE_HIGH);
+    expect(request.replacementOffset, 32);
+    expect(request.replacementLength, 3);
+  }
+
   test_library() {
     addTestSource('library foo;^');
     expect(computeFast(), isTrue);
     assertSuggestKeywords(DIRECTIVE_AND_DECLARATION_KEYWORDS,
         relevance: DART_RELEVANCE_HIGH);
   }
 
   test_library_declaration() {
     addTestSource('library ^');
     expect(computeFast(), isTrue);
@@ skipping 326 matching lines @@
         (c) => msg.writeln('  $c, ${other.contains(c) ? '' : '<<<<<<<<<<<'}'));
   }
 
   bool _equalSets(Iterable<String> iter1, Iterable<String> iter2) {
     if (iter1.length != iter2.length) return false;
     if (iter1.any((c) => !iter2.contains(c))) return false;
     if (iter2.any((c) => !iter1.contains(c))) return false;
     return true;
   }
 }