Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: runtime/vm/object.h

Issue 1278003002: Change heuristic to determine which fields contain modifieable double boxes: do it if field was ini… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: s Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 923168e879d2eb6ef088151af8fd9973f8822e16..8df34c1cb0a9bde6b7348ca5698d90bdd53a36c0 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -2817,6 +2817,12 @@ class Field : public Object {
bool is_reflectable() const {
return ReflectableBit::decode(raw_ptr()->kind_bits_);
}
+ bool is_double_initialized() const {
+ return DoubleInitializedBit::decode(raw_ptr()->kind_bits_);
+ }
+ void set_is_double_initialized(bool value) const {
+ set_kind_bits(DoubleInitializedBit::update(value, raw_ptr()->kind_bits_));
+ }
inline intptr_t Offset() const;
inline void SetOffset(intptr_t value_in_bytes) const;
@@ -2987,16 +2993,18 @@ class Field : public Object {
kFinalBit,
kHasInitializerBit,
kUnboxingCandidateBit,
- kReflectableBit
+ kReflectableBit,
+ kDoubleInitializedBit,
};
class ConstBit : public BitField<bool, kConstBit, 1> {};
class StaticBit : public BitField<bool, kStaticBit, 1> {};
class FinalBit : public BitField<bool, kFinalBit, 1> {};
class HasInitializerBit : public BitField<bool, kHasInitializerBit, 1> {};
class UnboxingCandidateBit : public BitField<bool,
- kUnboxingCandidateBit, 1> {
- };
+ kUnboxingCandidateBit, 1> {};
class ReflectableBit : public BitField<bool, kReflectableBit, 1> {};
+ class DoubleInitializedBit : public BitField<bool,
+ kDoubleInitializedBit, 1> {};
// Update guarded cid and guarded length for this field. Returns true, if
// deoptimization of dependent code is required.
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698