Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: content/public/browser/web_contents.h

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: caitp feedback Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/favicon_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 22f0fabafbb7a1f59683d2d9b18d53b61684f2fa..13cec7f735392b29fe987919ce53afa2e2dac0d2 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -412,19 +412,19 @@ class WebContents : public PageNavigator,
const GURL&, /* image_url */
int, /* requested_size */
const std::vector<SkBitmap>& /* bitmaps*/)>
- FaviconDownloadCallback;
+ ImageDownloadCallback;
- // Sends a request to download the given favicon |url| and returns the unique
+ // Sends a request to download the given image |url| and returns the unique
// id of the download request. When the download is finished, |callback| will
- // be called with the bitmaps received from the renderer. If [is_favicon|,
- // the cookeis are not sent and not accepted during download. Note that
+ // be called with the bitmaps received from the renderer. If |is_favicon| is
+ // true, the cookies are not sent and not accepted during download. Note that
// |image_size| is a hint for images with multiple sizes. The downloaded image
// is not resized to the given image_size. If 0 is passed, the first frame of
// the image is returned.
- virtual int DownloadFavicon(const GURL& url,
- bool is_favicon,
- int image_size,
- const FaviconDownloadCallback& callback) = 0;
+ virtual int DownloadImage(const GURL& url,
+ bool is_favicon,
+ int image_size,
+ const ImageDownloadCallback& callback) = 0;
private:
// This interface should only be implemented inside content.
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/favicon_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698