chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc - Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: caitp feedback Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

index 19f3dff7fc6c7ee37a828b64cedc68f17a9a97ef..505d061352b4997a183252ac7c24c786befaf1cb 100644

--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

@@ -109,7 +109,7 @@ void FaviconBitmapHandler::DidUpdateFaviconURL(

if (pending_requests_.find(*iter) != pending_requests_.end())

continue; // Skip already pending downloads.

pending_requests_.insert(*iter);

- web_contents_->DownloadFavicon(*iter, true, 0,

+ web_contents_->DownloadImage(*iter, true, 0,

base::Bind(&FaviconBitmapHandler::DidDownloadFavicon,

weak_ptr_factory_.GetWeakPtr()));

}